-
Notifications
You must be signed in to change notification settings - Fork 1
[Feat] Splash view UI 구현 #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
942334a
Chore: Lottie 외부 라이브러리 의존성 추가
choijungp 0b76b84
Docs: Splash json 파일 및 bitnail logo 이미지 asset 추가
choijungp 8e699eb
Feat: SplashView UI 구현
choijungp f3663b7
Chore: splash.json 파일 교체
choijungp c092eb4
Chore: splash.json 파일 교체
choijungp 87e0f44
Refactor: SplashViewDelegate 구현하여 애니메이션 완료하도록 수정
choijungp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
Projects/Presentation/Resources/Images.xcassets/bitnagil_logo.imageset/Contents.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "bitnagil_logo.png", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "filename" : "bitnagil_logo@2x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "filename" : "bitnagil_logo@3x.png", | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Binary file added
BIN
+1.51 KB
...Presentation/Resources/Images.xcassets/bitnagil_logo.imageset/bitnagil_logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.98 KB
...sentation/Resources/Images.xcassets/bitnagil_logo.imageset/bitnagil_logo@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.48 KB
...sentation/Resources/Images.xcassets/bitnagil_logo.imageset/bitnagil_logo@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
리소스 로딩 에러 처리 개선 필요
현재 구현에서 몇 가지 개선점이 있습니다:
splash.json파일을 찾지 못할 경우 silent failure가 발생합니다다음과 같이 개선하는 것을 고려해보세요:
private func configureAttribute() { let presentationBundle = Bundle(for: SplashView.self) guard let filePath = presentationBundle.path(forResource: "splash", ofType: "json") - else { return } + else { + print("Warning: splash.json file not found in bundle") + // fallback 처리 또는 기본 애니메이션 로직 추가 + return + } splashAnimationView = LottieAnimationView(filePath: filePath) splashAnimationView.contentMode = .scaleAspectFit splashAnimationView.loopMode = .playOnce logoImage.image = BitnagilGraphic.logoGraphic logoImage.contentMode = .scaleAspectFit }📝 Committable suggestion
🤖 Prompt for AI Agents