Skip to content

[Chore] 빌드 Workflow 수정#61

Merged
choijungp merged 1 commit intodevelopfrom
fix/workflows
Sep 4, 2025
Merged

[Chore] 빌드 Workflow 수정#61
choijungp merged 1 commit intodevelopfrom
fix/workflows

Conversation

@choijungp
Copy link
Copy Markdown
Contributor

@choijungp choijungp commented Sep 4, 2025

🌁 Background

build test 이젠 정말 될 것이여요 ...

👩‍💻 Contents

image

띵 PR 에서 대부분 그대로이고 .. Xcode 버전 세팅할 때 문서에 나와있는 default 버전 (16.4)으로만 바꿔줬어요 ...

✅ Testing

Fork 한 개인 레포에서 테스트 해봤어요 !!!
빌드 성공, 실패 모두 테스트 완 !!!!

📬 Reference

https://github.com/actions/runner-images/blob/main/images/macos/macos-15-Readme.md

Summary by CodeRabbit

  • Chores
    • CI 워크플로에서 사용하는 Xcode 버전을 16.2에서 16.4로 갱신했습니다. 이로써 빌드와 테스트가 최신 macOS/iOS 도구 체인에서 수행되며, 향후 릴리스 과정의 일관성과 호환성이 강화됩니다. 사용자 기능 변경은 없으며 앱 동작에는 영향이 없습니다.

@choijungp choijungp requested a review from taipaise September 4, 2025 08:33
@choijungp choijungp self-assigned this Sep 4, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 4, 2025

Walkthrough

CI 워크플로우에서 Set Xcode version 단계의 Xcode 경로를 /Applications/Xcode_16.2.app 에서 /Applications/Xcode_16.4.app 으로 변경했습니다. 다른 단계와 동작은 동일합니다.

Changes

Cohort / File(s) Summary
CI 워크플로우 업데이트
\.github/workflows/build_test.yml
Set Xcode version 단계의 경로를 Xcode_16.2.appXcode_16.4.app 으로 수정

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

깡충, 빌드 굴레를 살짝 넘었네
16.2에서 16.4로, 발굽 고쳐 매네 🐇
밤새는 테스트도 길을 묻지 않고
런너의 길 위에 달빛이 번지고
“다음 점프는 어디로?” 칸반이 웃네 ✨

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or @coderabbitai 요약 to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/build_test.yml (2)

20-24: curl | sh 설치 경로는 버전/무결성 고정 고려.

Mise 설치를 파이프 실행으로 받으면 재현성/보안 면에서 취약합니다. 버전 고정 또는 체크섬 검증, 혹은 mise/tuist 버전을 명시적으로 핀(예: tuist@<version>)하는 것을 권장합니다.

예시:

-          mise install tuist
-          mise use -g tuist
+          mise install tuist@<PINNED_VERSION>
+          mise use -g tuist@<PINNED_VERSION>

10-10: macOS 실행기 버전을 macos-14로 고정 (github.blog)
macos-latest는 현재 macOS 14(Sonoma)에 매핑되며, 향후 메이저 버전 자동 전환을 방지하려면 구체적인 버전(macos-14)으로 고정하는 것이 안전합니다. (github.blog)

-    runs-on: macos-latest
+    runs-on: macos-14
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 673dc3c and 89a8057.

📒 Files selected for processing (1)
  • .github/workflows/build_test.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (2)
.github/workflows/build_test.yml (2)

46-47: OS/시뮬레이터 가용성 확인 필요
현재 환경에서 xcrun이 없어 자동 스크립트 검증이 실패했습니다. CI 또는 macOS 환경에서 아래 명령을 실행해 OS=latest 조합이 유효한지 확인하세요.

-            -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.4' \
+            -destination 'platform=iOS Simulator,OS=latest,name=iPhone 16' \

16-17: macOS 런너에서 setup-xcode 액션 동작 검증 필요
현재 로컬 Linux 환경에 xcode-select 명령이 없어 변경 내용 검증이 불가하므로 GitHub Actions의 macOS 런너에서 Xcode 버전 설정이 올바르게 적용되는지 확인해주세요.

@choijungp choijungp merged commit 0c25322 into develop Sep 4, 2025
2 checks passed
@choijungp choijungp deleted the fix/workflows branch September 4, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant