[NDGL-118] refactor: 코드래빗 리뷰 반영

- AddItineraryRequest 타입 수정 : String? -> Int?
- handleAddPlace() : lastPlace가 null 일때 로직 추가
- placeRepository: 주석 제거
- toOpeningHours: day <= 0 체크 추가, java.time.* 의존성 -> kotlinx.datetime으로 수정
- toTransportationItem() 최소값 1분으로 수정

Author: mj010504

data/travel/src/main/java/com/yapp/ndgl/data/travel/model/AddItineraryRequest.kt

@@ -9,7 +9,7 @@ data class AddItineraryRequest(
     val day: Int,
     val sequence: Int,
     val startTime: String? = null,
-    val estimatedDuration: String? = null,
+    val estimatedDuration: Int,
     val memo: String? = null,
     @SerialName("budget")
     val cost: Int? = null,

data/travel/src/main/java/com/yapp/ndgl/data/travel/repository/PlaceRepository.kt

@@ -34,7 +34,6 @@ class PlaceRepository @Inject constructor(
         val requestBuilder = FindAutocompletePredictionsRequest.builder()
             .setQuery(keyword)
             .setSessionToken(sessionToken)
-            // .setCountries(countryCode)
             .setLocationBias(bias)
 
         val response = placesClient.findAutocompletePredictions(requestBuilder.build()).await()

data/travel/src/main/java/com/yapp/ndgl/data/travel/repository/UserTravelRepository.kt

@@ -138,7 +138,7 @@ class UserTravelRepository @Inject constructor(
         day: Int,
         sequence: Int,
         startTime: String? = null,
-        estimatedDuration: String? = null,
+        estimatedDuration: Int,
         cost: Int? = null,
         memo: String? = null,
         distanceKm: Double? = null,

feature/travel/src/main/java/com/yapp/ndgl/feature/travel/model/PlaceInfo.kt

@@ -2,9 +2,10 @@ package com.yapp.ndgl.feature.travel.model
 
 import com.yapp.ndgl.core.util.formatDecimal
 import com.yapp.ndgl.data.travel.model.PlaceDetailResponse
-import java.time.DayOfWeek
-import java.time.LocalDate
-import java.time.format.DateTimeFormatter
+import kotlinx.datetime.DateTimeUnit
+import kotlinx.datetime.DayOfWeek
+import kotlinx.datetime.LocalDate
+import kotlinx.datetime.plus
 import kotlin.time.Duration
 import kotlin.time.Duration.Companion.hours
 
@@ -62,12 +63,13 @@ fun PlaceDetailResponse.toPlaceInfo(): PlaceInfo {
         websiteUrl = place.websiteUri,
     )
 }
+
 fun List<String>?.toOpeningHours(startDate: String, day: Int): String? {
-    if (this.isNullOrEmpty() || startDate.isBlank()) return null
+    if (this.isNullOrEmpty() || startDate.isBlank() || day <= 0) return null
 
     val targetDayOfWeek = runCatching {
-        val travelStartDate = LocalDate.parse(startDate, DateTimeFormatter.ISO_LOCAL_DATE)
-        val targetDate = travelStartDate.plusDays((day - 1).toLong())
+        val travelStartDate = LocalDate.parse(startDate)
+        val targetDate = travelStartDate.plus(day - 1, DateTimeUnit.DAY)
         targetDate.dayOfWeek
     }.getOrNull() ?: return null
 

feature/travel/src/main/java/com/yapp/ndgl/feature/travel/model/TransportSegment.kt

@@ -32,7 +32,7 @@ data class TransportSegment(
     fun toTransportationItem(): TransportationItem {
         return TransportationItem(
             mode = type.toTransportCategory(),
-            timeMin = duration.inWholeMinutes.toInt(),
+            timeMin = duration.inWholeMinutes.toInt().coerceAtLeast(1),
         )
     }
 }

feature/travel/src/main/java/com/yapp/ndgl/feature/travel/traveldetail/TravelDetailViewModel.kt

@@ -117,18 +117,23 @@ class TravelDetailViewModel @AssistedInject constructor(
         val dayIndex = event.day - 1
         val currentItinerary = state.value.itineraries.getOrNull(dayIndex) ?: return
         val newSequence = currentItinerary.places.size + 1
-        val lastPlace = currentItinerary.places.last()
+        val lastPlace = currentItinerary.places.lastOrNull()
 
         // 추가된 장소로 가는 교통수단 계산
-        val newTransportSegment = computeRoute(
-            originLatitude = lastPlace.placeInfo.latitude,
-            originLongitude = lastPlace.placeInfo.longitude,
-            destinationLatitude = event.latitude,
-            destinationLongitude = event.longitude,
-            newGooglePlaceId = event.googlePlaceId,
-            travelMode = TravelMode.TRANSIT,
-        )
-        val (distanceKm, transportation) = if (currentItinerary.places.isNotEmpty()) {
+        val newTransportSegment = if (lastPlace != null) {
+            computeRoute(
+                originLatitude = lastPlace.placeInfo.latitude,
+                originLongitude = lastPlace.placeInfo.longitude,
+                destinationLatitude = event.latitude,
+                destinationLongitude = event.longitude,
+                newGooglePlaceId = event.googlePlaceId,
+                travelMode = TravelMode.TRANSIT,
+            )
+        } else {
+            null
+        }
+
+        val (distanceKm, transportation) = if (!currentItinerary.places.isNullOrEmpty()) {
             newTransportSegment?.distanceKm to listOfNotNull(newTransportSegment?.toTransportationItem())
         } else {
             null to null
@@ -140,8 +145,17 @@ class TravelDetailViewModel @AssistedInject constructor(
                 googlePlaceId = event.googlePlaceId,
                 day = event.day,
                 sequence = newSequence,
-                startTime = null,
-                estimatedDuration = "${event.estimatedDuration}",
+                startTime = if (lastPlace == null) {
+                    null
+                } else {
+                    (
+                        lastPlace.startTime + lastPlace.placeInfo.estimatedDuration + (
+                            newTransportSegment?.duration
+                                ?: 0.hours
+                            )
+                        ).parseDurationToTimeString()
+                },
+                estimatedDuration = event.estimatedDuration,
                 cost = null,
                 memo = null,
                 distanceKm = distanceKm,
@@ -166,7 +180,8 @@ class TravelDetailViewModel @AssistedInject constructor(
                 userData = TravelPlace.UserData(
                     estimatedDuration = response.estimatedDuration.minutes,
                 ),
-                startTime = lastPlace.startTime + lastPlace.placeInfo.estimatedDuration + (newTransportSegment?.duration ?: 0.hours),
+                startTime = (lastPlace?.startTime ?: Itinerary.DEFAULT_START_TIME.hours) +
+                    (lastPlace?.placeInfo?.estimatedDuration ?: 1.hours) + (newTransportSegment?.duration ?: 0.hours),
                 transportToNext = null,
             )