[NDGL-16] detekt, ktlint 적용 및 CI/CD 구성

.claude/settings.local.json

@@ -0,0 +1,9 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(git add:*)",
+      "Bash(git rebase:*)",
+      "Bash(git fetch:*)"
+    ]
+  }
+}

.editorconfig

@@ -0,0 +1,14 @@
+root = true
+
+[*]
+charset = utf-8
+indent_size = 4
+indent_style = space
+max_line_length = 150
+insert_final_newline = true
+trim_trailing_whitespace = true
+
+[*.{kt,kts}]
+ij_kotlin_allow_trailing_comma = true
+ij_kotlin_allow_trailing_comma_on_call_site = true
+ktlint_function_naming_ignore_when_annotated_with = Composable

.github/workflows/android_ci.yml

@@ -0,0 +1,37 @@
+name: Android CI
+
+on:
+  push:
+    branches: [ "develop" ]
+  pull_request:
+    branches: [ "develop" ]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Setup Gradle
+      uses: gradle/actions/setup-gradle@v4
+      with:
+          gradle-home-cache-cleanup: true
+
+    - name: Set up JDK 21
+      uses: actions/setup-java@v4
+      with:
+        java-version: '21'
+        distribution: 'temurin'
+
+    - name: Grant execute permission for gradlew
+      run: chmod +x gradlew
+
+    - name: Set up local.properties
+      run: echo "${{ secrets.LOCAL_PROPERTIES }}" > local.properties
+
+    - name: Code style checks
+      run: ./gradlew ktlintCheck detekt
+
+    - name: Run build
+      run: ./gradlew assembleDebug --stacktrace

app/build.gradle.kts

@@ -4,6 +4,12 @@ plugins {
 
 android {
     namespace = Configuration.APPLICATION_ID
+
+    buildTypes {
+        release {
+            isMinifyEnabled = true
+        }
+    }
 }
 
 dependencies {

app/src/main/java/com/yapp/ndgl/MainActivity.kt

@@ -20,4 +20,3 @@ class MainActivity : ComponentActivity() {
         }
     }
 }
-

app/src/main/java/com/yapp/ndgl/navigation/BottomNavTab.kt

@@ -1,7 +1,6 @@
 package com.yapp.ndgl.navigation
 
 import androidx.annotation.DrawableRes
-import com.yapp.ndgl.navigation.Route
 import com.yapp.ndgl.core.ui.R
 
 enum class BottomNavTab(
@@ -24,5 +23,4 @@ enum class BottomNavTab(
         label = "여행",
         route = Route.Travel,
     ),
-    ;
 }

app/src/main/java/com/yapp/ndgl/ui/BottomNavigationBar.kt

@@ -12,8 +12,8 @@ import com.yapp.ndgl.navigation.Route
 
 @Composable
 internal fun BottomNavigationBar(
-    currentTab : Route,
-    onTabSelected : (Route) -> Unit,
+    currentTab: Route,
+    onTabSelected: (Route) -> Unit,
 ) {
     // FIXME 네비게이션 바 디자인 수정 및 추상화
     NavigationBar {
@@ -24,10 +24,10 @@ internal fun BottomNavigationBar(
                 icon = {
                     Icon(
                         imageVector = ImageVector.vectorResource(id = topLevelRoute.icon),
-                        contentDescription = topLevelRoute.label
+                        contentDescription = topLevelRoute.label,
                     )
                 },
-                label = { Text(text = topLevelRoute.label) }
+                label = { Text(text = topLevelRoute.label) },
             )
         }
     }

app/src/main/java/com/yapp/ndgl/ui/NDGLApp.kt

@@ -9,19 +9,20 @@ import androidx.compose.runtime.remember
 import androidx.compose.ui.Modifier
 import androidx.navigation3.runtime.entryProvider
 import androidx.navigation3.ui.NavDisplay
-import com.yapp.ndgl.feature.travelhelper.navigation.travelHelperEntry
 import com.yapp.ndgl.feature.home.navigation.homeEntry
+import com.yapp.ndgl.feature.travel.navigation.travelEntry
+import com.yapp.ndgl.feature.travelhelper.navigation.travelHelperEntry
 import com.yapp.ndgl.navigation.BottomNavTab
 import com.yapp.ndgl.navigation.Navigator
 import com.yapp.ndgl.navigation.Route
 import com.yapp.ndgl.navigation.rememberNavigationState
 import com.yapp.ndgl.navigation.toEntries
-import com.yapp.ndgl.feature.travel.navigation.travelEntry
 
 @Composable
 fun NDGLApp() {
     val navigationState = rememberNavigationState(
-        startRoute = Route.Home, topLevelKeys = BottomNavTab.entries.map { it.route }.toSet(),
+        startRoute = Route.Home,
+        topLevelKeys = BottomNavTab.entries.map { it.route }.toSet(),
     )
     val navigator = remember { Navigator(navigationState) }
 
@@ -31,7 +32,8 @@ fun NDGLApp() {
         travelHelperEntry(navigator)
     }
 
-    val shouldShowBottomBar = remember(navigationState.currentKey) { navigationState.currentKey in navigationState.topLevelKeys }
+    val shouldShowBottomBar =
+        remember(navigationState.currentKey) { navigationState.currentKey in navigationState.topLevelKeys }
 
     Scaffold(
         modifier = Modifier.fillMaxSize(),
@@ -55,4 +57,3 @@ fun NDGLApp() {
         )
     }
 }
-

build-logic/src/main/kotlin/NDGLAndroidLibraryPlugin.kt

@@ -1,6 +1,6 @@
 import convention.configureComposeAndroid
 import convention.configureFirebase
-import extensions.configureAndroidLibrary
+import convention.configureKotlinAndroid
 import org.gradle.api.Plugin
 import org.gradle.api.Project
 import org.gradle.kotlin.dsl.dependencies
@@ -13,7 +13,7 @@ class NDGLAndroidLibraryPlugin : Plugin<Project> {
             apply("org.jetbrains.kotlin.android")
         }
 
-        configureAndroidLibrary()
+        configureKotlinAndroid()
         configureFirebase()
         configureComposeAndroid()
 

build-logic/src/main/kotlin/NDGLApplicationPlugin.kt

@@ -2,7 +2,6 @@ import convention.configureComposeAndroid
 import convention.configureHiltAndroid
 import convention.configureKotlinAndroid
 import convention.configureTimber
-import extensions.configureAndroidApplication
 import org.gradle.api.Plugin
 import org.gradle.api.Project
 
@@ -13,7 +12,6 @@ class NDGLApplicationPlugin : Plugin<Project> {
         }
 
         configureKotlinAndroid()
-        configureAndroidApplication()
         configureHiltAndroid()
         configureTimber()
         configureComposeAndroid()

build-logic/src/main/kotlin/NDGLDataPlugin.kt

@@ -1,7 +1,6 @@
 import convention.configureCoroutineAndroid
 import convention.configureHiltAndroid
 import convention.configureKotlinAndroid
-import extensions.configureAndroidLibrary
 import org.gradle.api.Plugin
 import org.gradle.api.Project
 
@@ -12,7 +11,6 @@ class NDGLDataPlugin : Plugin<Project> {
         }
 
         configureKotlinAndroid()
-        configureAndroidLibrary()
         configureHiltAndroid()
         configureCoroutineAndroid()
     }

build-logic/src/main/kotlin/NDGLFeaturePlugin.kt

@@ -2,7 +2,6 @@ import convention.configureComposeAndroid
 import convention.configureCoroutineAndroid
 import convention.configureFirebase
 import convention.configureHiltAndroid
-import extensions.configureAndroidLibrary
 import org.gradle.api.Plugin
 import org.gradle.api.Project
 import org.gradle.kotlin.dsl.dependencies
@@ -11,14 +10,10 @@ import util.libs
 class NDGLFeaturePlugin : Plugin<Project> {
     override fun apply(target: Project): Unit = with(target) {
         with(pluginManager) {
-            apply("com.android.library")
-            apply("org.jetbrains.kotlin.android")
+            apply("ndgl.android.library")
         }
 
-        configureAndroidLibrary()
         configureHiltAndroid()
-        configureFirebase()
-        configureComposeAndroid()
         configureCoroutineAndroid()
 
         dependencies {

build-logic/src/main/kotlin/NDGLKotlinLibraryPlugin.kt

@@ -1,13 +1,35 @@
-
-import extensions.configureKotlinJvm
 import org.gradle.api.Plugin
 import org.gradle.api.Project
+import org.gradle.api.plugins.JavaPluginExtension
+import org.gradle.kotlin.dsl.configure
+import org.gradle.kotlin.dsl.dependencies
+import org.jetbrains.kotlin.gradle.dsl.JvmTarget
+import org.jetbrains.kotlin.gradle.dsl.KotlinJvmProjectExtension
+import util.libs
 
 class NDGLKotlinLibraryPlugin : Plugin<Project> {
     override fun apply(target: Project): Unit = with(target) {
         with(pluginManager) {
             apply("org.jetbrains.kotlin.jvm")
         }
+
         configureKotlinJvm()
+
+        dependencies {
+            "detektPlugins"(libs.findLibrary("detekt.formatting").get())
+        }
+    }
+}
+
+internal fun Project.configureKotlinJvm() {
+    extensions.configure<JavaPluginExtension> {
+        sourceCompatibility = Configuration.JAVA_VERSION
+        targetCompatibility = Configuration.JAVA_VERSION
+    }
+
+    extensions.configure<KotlinJvmProjectExtension> {
+        compilerOptions {
+            jvmTarget.set(JvmTarget.fromTarget(Configuration.JVM_TARGET))
+        }
     }
 }

build-logic/src/main/kotlin/convention/KotlinAndroid.kt

@@ -20,6 +20,15 @@ internal fun Project.configureKotlinAndroid() {
         defaultConfig {
             minSdk = Configuration.MIN_SDK
         }
+        buildTypes {
+            getByName("release") {
+                isMinifyEnabled = false
+                proguardFiles(
+                    getDefaultProguardFile("proguard-android-optimize.txt"),
+                    "proguard-rules.pro",
+                )
+            }
+        }
         compileOptions {
             sourceCompatibility = Configuration.JAVA_VERSION
             targetCompatibility = Configuration.JAVA_VERSION
@@ -39,6 +48,7 @@ internal fun Project.configureKotlinAndroid() {
 
     dependencies {
         "coreLibraryDesugaring"(libs.findLibrary("android.desugarJdkLibs").get())
+        "detektPlugins"(libs.findLibrary("detekt.formatting").get())
     }
 }
 
@@ -51,7 +61,7 @@ internal fun Project.configureKotlin() {
             freeCompilerArgs.set(
                 freeCompilerArgs.get() + listOf(
                     "-opt-in=kotlin.RequiresOptIn",
-                )
+                ),
             )
         }
     }