Skip to content

Commit 56ca841

Browse files
committed
[BOOK-474] chore: GOOGLE_WEB_CLIENT_ID 하나로 통일
하나의 GOOGLE_WEB_CLIENT_ID를 단일 앱(패키지 네임)에서만 시용할 수 있는 것은 아니기 때문에 dev/release 공통 web_client_id를 사용
1 parent ad7a380 commit 56ca841

2 files changed

Lines changed: 3 additions & 10 deletions

File tree

app/build.gradle.kts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ android {
3232
getByName("debug") {
3333
isDebuggable = true
3434
applicationIdSuffix = ".dev"
35-
buildConfigField("String", "GOOGLE_WEB_CLIENT_ID", getLocalProperty("DEBUG_GOOGLE_WEB_CLIENT_ID"))
3635
manifestPlaceholders += mapOf(
3736
"appName" to "@string/app_name_dev",
3837
)
@@ -43,7 +42,6 @@ android {
4342
isMinifyEnabled = true
4443
isShrinkResources = true
4544
signingConfig = signingConfigs.getByName("release")
46-
buildConfigField("String", "GOOGLE_WEB_CLIENT_ID", getLocalProperty("RELEASE_GOOGLE_WEB_CLIENT_ID"))
4745
manifestPlaceholders += mapOf(
4846
"appName" to "@string/app_name",
4947
)
@@ -55,6 +53,7 @@ android {
5553
}
5654

5755
defaultConfig {
56+
buildConfigField("String", "GOOGLE_WEB_CLIENT_ID", getLocalProperty("GOOGLE_WEB_CLIENT_ID"))
5857
buildConfigField("String", "KAKAO_NATIVE_APP_KEY", getLocalProperty("KAKAO_NATIVE_APP_KEY"))
5958
manifestPlaceholders["KAKAO_NATIVE_APP_KEY"] = getLocalProperty("KAKAO_NATIVE_APP_KEY").trim('"')
6059
}

feature/login/build.gradle.kts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,8 @@ plugins {
1111
android {
1212
namespace = "com.ninecraft.booket.feature.login"
1313

14-
buildTypes {
15-
getByName("debug") {
16-
buildConfigField("String", "GOOGLE_WEB_CLIENT_ID", getLocalProperty("DEBUG_GOOGLE_WEB_CLIENT_ID"))
17-
}
18-
19-
getByName("release") {
20-
buildConfigField("String", "GOOGLE_WEB_CLIENT_ID", getLocalProperty("RELEASE_GOOGLE_WEB_CLIENT_ID"))
21-
}
14+
defaultConfig {
15+
buildConfigField("String", "GOOGLE_WEB_CLIENT_ID", getLocalProperty("GOOGLE_WEB_CLIENT_ID"))
2216
}
2317

2418
buildFeatures {

0 commit comments

Comments
 (0)