Conversation
WalkthroughFirebase App Distribution 워크플로우에서 배포 대상 그룹을 testers에서 reed-android-testers로 변경했습니다. 다른 설정과 단계는 변경되지 않았습니다. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/android-cd.yml (2)
105-105: Firebase App Distribution 그룹 변경 — 존재/권한 확인 필요
reed-android-testers그룹 alias가 Firebase 콘솔(App Distribution)에서 실제로 존재하는지, 그리고 업로드에 사용하는 서비스 계정(serviceCredentialsFileContent)에 App Distribution 업로드 권한이 있는지 확인해 주세요. 그룹 alias는 쉼표로 구분된 문자열 목록이며, 별칭 철자/대소문자 불일치로 인한 실패가 빈번합니다. 필요 시 그룹을 리포지토리 변수로 외부화해 운영 환경별로 쉽게 전환하는 것도 권장합니다.선택 사항: 그룹을 변수로 관리하는 예시
jobs: cd-build: runs-on: ubuntu-latest + env: + FIREBASE_DIST_GROUPS: ${{ vars.FIREBASE_DIST_GROUPS || 'reed-android-testers' }} ... - name: Upload artifact to Firebase App Distribution uses: wzieba/Firebase-Distribution-Github-Action@v1 with: appId: ${{secrets.FIREBASE_RELEASE_APP_ID}} serviceCredentialsFileContent: ${{ secrets.CREDENTIAL_FILE_CONTENT }} - groups: reed-android-testers + groups: ${{ env.FIREBASE_DIST_GROUPS }} file: app/build/outputs/bundle/release/app-release.aab releaseNotes: ${{ steps.firebase_release_note.outputs.notes }}
7-11: PR 이벤트에서 배포/릴리스까지 실행되는 플로우 — 의도 확인 필요이 워크플로우는 pull_request 트리거에서 바로 AAB 빌드, GitHub Release 생성, Firebase 배포까지 수행합니다. 포크에서 온 PR에는 시크릿이 전달되지 않아 실패할 수 있고, PR 단계에서 릴리스/배포를 실행하는 것은 운영 정책에 따라 부적절할 수 있습니다. 원하시는 동작이 “머지 후” 혹은 “태그 푸시 시” 배포라면 트리거 또는 스텝 조건을 조정해 주세요.
예시: 배포/릴리스는 push(main, tags)에서만 실행하도록 조건 추가
on: - pull_request: - branches: - - main + pull_request: + branches: [ main ] + push: + branches: [ main ] + tags: + - 'v*' ... - - name: Create Github Release + - name: Create Github Release + if: ${{ github.event_name == 'push' }} uses: softprops/action-gh-release@v2 with: tag_name: ${{ steps.extract_version.outputs.version }} release_name: ${{ steps.extract_version.outputs.version }} generate_release_notes: true - - name: Upload artifact to Firebase App Distribution + - name: Upload artifact to Firebase App Distribution + if: ${{ github.event_name == 'push' }} uses: wzieba/Firebase-Distribution-Github-Action@v1Also applies to: 93-109
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (20)
core/designsystem/src/main/res/drawable/img_emotion_insight.pngis excluded by!**/*.pngcore/designsystem/src/main/res/drawable/img_emotion_joy.pngis excluded by!**/*.pngcore/designsystem/src/main/res/drawable/img_emotion_sadness.pngis excluded by!**/*.pngcore/designsystem/src/main/res/drawable/img_emotion_warmth.pngis excluded by!**/*.pngfeature/detail/src/main/res/drawable/img_insight.pngis excluded by!**/*.pngfeature/detail/src/main/res/drawable/img_joy.pngis excluded by!**/*.pngfeature/detail/src/main/res/drawable/img_sad.pngis excluded by!**/*.pngfeature/detail/src/main/res/drawable/img_warm.pngis excluded by!**/*.pngfeature/home/src/main/res/drawable/img_empty_book.pngis excluded by!**/*.pngfeature/home/src/main/res/drawable/img_home_seed.pngis excluded by!**/*.pngfeature/home/src/main/res/drawable/img_reed_logo.pngis excluded by!**/*.pngfeature/home/src/main/res/drawable/img_seed_count.pngis excluded by!**/*.pngfeature/login/src/main/res/drawable/img_reed_logo_big.pngis excluded by!**/*.pngfeature/onboarding/src/main/res/drawable/img_onboarding_first.pngis excluded by!**/*.pngfeature/onboarding/src/main/res/drawable/img_onboarding_second.pngis excluded by!**/*.pngfeature/onboarding/src/main/res/drawable/img_onboarding_third.pngis excluded by!**/*.pngfeature/record/src/main/res/drawable/img_frame_marker.pngis excluded by!**/*.pngfeature/record/src/main/res/drawable/img_record_complete.pngis excluded by!**/*.pngfeature/search/src/main/res/drawable/img_book_register_complete.pngis excluded by!**/*.pngfeature/splash/src/main/res/drawable/ic_reed_logo.pngis excluded by!**/*.png
📒 Files selected for processing (1)
.github/workflows/android-cd.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/android-cd.yml (1)
1-109: PR 설명과 실제 변경 파일의 불일치PR 설명은 PNG→WebP 변환(용량 최적화)을 주된 변경점으로 서술하고 있으나, 본 워크플로우 파일에서는 Firebase 배포 그룹만 변경되었습니다. 실질적인 리소스 변환 커밋이 동일 PR에 포함되어 있는지, 혹은 별도 PR로 분리했는지 확인 부탁드립니다. 릴리스 노트 자동 생성 단계가 PR 제목/커밋을 그대로 노출하므로, 변경 내용과 릴리스 산출물의 일관성을 유지하는 것이 좋습니다.
Merged
Contributor
|
@easyhooon 우클릭 > Convert to WebP 
|
Contributor
Author
우클릭 > Convert to WebP 몰랐슴다 이게 더 좋을 것 같네요 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
📙 작업 설명
🧪 테스트 내역 (선택)
💬 추가 설명 or 리뷰 포인트 (선택)
Summary by CodeRabbit