-
Notifications
You must be signed in to change notification settings - Fork 0
fix: 약관동의 API 네트워크 에러 핸들링 #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3720fca
b1645f8
12cd888
1401a84
53cd427
e919ffb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,5 @@ | |
| <string name="book_status_completed">독서 완료</string> | ||
| <string name="record_sort_page_ascending">페이지순</string> | ||
| <string name="record_sort_recent_register">최신 등록순</string> | ||
| <string name="confirm">확인</string> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainRetry 라벨의 리소스 위치 일관성 확인 및 중앙화 제안 Splash에서 다음 스크립트로 필요 시 core-common에 <string name="record_sort_recent_register">최신 등록순</string>
<string name="confirm">확인</string>
+ <string name="retry">다시 시도</string>🏁 Script executed: #!/bin/bash
# retry 문자열 리소스 정의 위치 검색
rg -n -C1 -g '**/res/values/**/*.xml' '<string\s+name="retry">\s*([^<]+)\s*</string>'Length of output: 393 Retry 라벨 리소스 중앙화 및 문구 통일 필요 현재 수정 제안:
🤖 Prompt for AI Agents |
||
| </resources> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,10 +6,13 @@ import androidx.compose.runtime.getValue | |
| import androidx.compose.runtime.mutableStateOf | ||
| import androidx.compose.runtime.rememberCoroutineScope | ||
| import androidx.compose.runtime.setValue | ||
| import com.ninecraft.booket.core.common.constants.ErrorScope | ||
| import com.ninecraft.booket.core.common.utils.postErrorDialog | ||
| import com.ninecraft.booket.core.data.api.repository.AuthRepository | ||
|
Comment on lines
+9
to
11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainR 소스 모듈 확인: retry 리소스가 core-ui가 아닌 다른 모듈에 있을 수 있습니다. 현재 아래 스크립트로 Also applies to: 15-15 🏁 Script executed: #!/bin/bash
# retry 문자열 정의 위치 나열
rg -n -C1 -g '**/res/values/**/*.xml' '<string\s+name="retry">\s*([^<]+)\s*</string>'
# SplashPresenter에서 실제로 어떤 R을 import하는지 출력
fd -t f 'SplashPresenter.kt' -E '.gradle' -E 'build' \
| xargs -I{} rg -n 'import\s+.*\.R\b' {}Length of output: 528 아래 스크립트로 🏁 Script executed: #!/bin/bash
# confirm 문자열 정의 위치 나열
rg -n -C1 -g '**/res/values/**/*.xml' '<string\s+name="confirm">\s*([^<]+)\s*</string>'Length of output: 342 UI 리소스 모듈 일관성 검토: retry(core-ui) vs confirm(core-common)
🤖 Prompt for AI Agents |
||
| import com.ninecraft.booket.core.data.api.repository.UserRepository | ||
| import com.ninecraft.booket.core.model.AutoLoginState | ||
| import com.ninecraft.booket.core.model.OnboardingState | ||
| import com.ninecraft.booket.core.ui.R | ||
| import com.ninecraft.booket.feature.screens.HomeScreen | ||
| import com.ninecraft.booket.feature.screens.LoginScreen | ||
| import com.ninecraft.booket.feature.screens.OnboardingScreen | ||
|
|
@@ -50,8 +53,13 @@ class SplashPresenter @AssistedInject constructor( | |
| navigator.resetRoot(LoginScreen) | ||
| } | ||
| } | ||
| .onFailure { | ||
| navigator.resetRoot(LoginScreen) | ||
| .onFailure { exception -> | ||
| postErrorDialog( | ||
| errorScope = ErrorScope.GLOBAL, | ||
| exception = exception, | ||
| buttonLabelResId = R.string.retry, | ||
| action = { checkTermsAgreement() }, | ||
| ) | ||
| } | ||
| } | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
놓치신 거 같아서 슬쩍 제안드려용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
억 붙였다고 생각하고 있었는데 빼먹었군여,, 다음 PR에 어노테이션 추가해야겠슴다...!