-
Notifications
You must be signed in to change notification settings - Fork 0
fix: 디자인 QA 반영 #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 디자인 QA 반영 #147
Changes from all commits
329a3c2
93447c9
108058b
86c3e38
16cddb4
f3b992c
875744e
210cd24
83aa432
07af68c
16e94be
662f53a
0fbfb09
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -52,7 +52,8 @@ fun ReviewBox( | |||||||||||||
| contentDescription = "Emotion Graphic", | ||||||||||||||
| modifier = Modifier | ||||||||||||||
| .size(ReedTheme.spacing.spacing10) | ||||||||||||||
| .clip(CircleShape), | ||||||||||||||
| .clip(CircleShape) | ||||||||||||||
| .background(ReedTheme.colors.basePrimary), | ||||||||||||||
| ) | ||||||||||||||
|
Comment on lines
+55
to
57
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion 원형 배경이 사각으로 렌더링될 수 있음 — background에 Shape 지정 필요
- .clip(CircleShape)
- .background(ReedTheme.colors.basePrimary),
+ .clip(CircleShape)
+ .background(ReedTheme.colors.basePrimary, CircleShape),📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
| Spacer(modifier = Modifier.width(ReedTheme.spacing.spacing2)) | ||||||||||||||
| Text( | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
원형 배경이 사각으로 렌더링될 수 있음 — background에 Shape 지정 필요
clip(CircleShape)다음에background(color)만 호출하면 배경은 사각형으로 그려집니다. 디자인 의도(원형 배경)에 맞추려면background에shape를 명시해 주세요.적용 예시:
📝 Committable suggestion
🤖 Prompt for AI Agents