-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 등록 도서 삭제 기능 구현 #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: 등록 도서 삭제 기능 구현 #153
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7a18514
[BOOK-272] chore: 필요 없는 어노테이션 제거
easyhooon 52c982b
[BOOK-272] chore: ErrorDialogSpec @StringRes 어노테이션 추가
easyhooon 2f278af
[BOOK-272] refactor: 각 feature 모듈내 UiState @Immutable 어노테이션 추가
easyhooon 79777d2
[BOOK-272] chore: InfinityLazyColumn limitCount default value 상수로 통일
easyhooon 25eded3
[BOOK-272] feat: 내 서재에 저장한 도서 삭제 API 연동
easyhooon 59b8510
Merge remote-tracking branch 'origin/develop' into BOOK-272-feature/#148
easyhooon 71a931b
[BOOK-272] feat: 기록 화면 누락된 imePadding 적용 및 Scaffold contentWindowInse…
easyhooon fbceb2a
[BOOK-272] feat: 등록한 도서 삭제 기능 구현
easyhooon 11b435a
[BOOK-272] chore: remove -> delete 삭제 워딩 통일
easyhooon 7c0c118
[BOOK-272] chore: 로그 및 contentDescription remove -> delete 삭제 워딩 통일
easyhooon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 3 additions & 1 deletion
4
core/common/src/main/kotlin/com/ninecraft/booket/core/common/constants/ErrorDialogSpec.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| package com.ninecraft.booket.core.common.constants | ||
|
|
||
| import androidx.annotation.StringRes | ||
|
|
||
| data class ErrorDialogSpec( | ||
| val message: String, | ||
| val buttonLabelResId: Int, | ||
| @StringRes val buttonLabelResId: Int, | ||
| val action: () -> Unit, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
도서 삭제 다이얼로그 문구 수정 필요: ‘기록’ → ‘도서’
현재 도서 삭제 다이얼로그가 기록 삭제 문자열을 사용하고 있어 사용자에게 혼동을 줄 수 있습니다. strings.xml에 제안한 book_delete_dialog_title을 사용하도록 변경해 주세요. 또한 앞선 코멘트대로 이벤트 명칭을 OnBookDeleteDialogDismiss로 바꿀 경우, 참조도 함께 조정합니다.
적용 diff:
📝 Committable suggestion
🤖 Prompt for AI Agents