Skip to content

fix: Dialog 혹은 BottomSheet를 통해 navigation 하는 경우 해당 컴포넌트가 닫히기 전 화면이 먼저 전환되는 문제 임시 해결 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seoyoon513 merged 1 commit into from
Aug 1, 2025
Merged

fix: Dialog 혹은 BottomSheet를 통해 navigation 하는 경우 해당 컴포넌트가 닫히기 전 화면이 먼저 전환되는 문제 임시 해결 #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...d/src/main/kotlin/com/ninecraft/booket/feature/record/register/RecordRegisterPresenter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import com.ninecraft.booket.feature.screens.LoginScreen
import com.ninecraft.booket.feature.screens.OcrScreen
import com.ninecraft.booket.feature.screens.RecordDetailScreen
import com.ninecraft.booket.feature.screens.RecordScreen
import com.ninecraft.booket.feature.screens.delayedPop
import com.orhanobut.logger.Logger
import com.slack.circuit.codegen.annotations.CircuitInject
import com.slack.circuit.foundation.rememberAnsweringNavigator
Expand Down Expand Up @@ -151,7 +152,9 @@ class RecordRegisterPresenter @AssistedInject constructor(

is RecordRegisterUiEvent.OnExitDialogConfirm -> {
isExitDialogVisible = false
navigator.pop()
scope.launch {
navigator.delayedPop()
}
}

is RecordRegisterUiEvent.OnExitDialogDismiss -> {
Expand Down Expand Up @@ -224,7 +227,9 @@ class RecordRegisterPresenter @AssistedInject constructor(

is RecordRegisterUiEvent.OnRecordSavedDialogDismiss -> {
isRecordSavedDialogVisible = false
navigator.pop()
scope.launch {
navigator.delayedPop()
}
}
}
}
Expand Down
14 changes: 14 additions & 0 deletions feature/screens/src/main/kotlin/com/ninecraft/booket/feature/screens/extensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.ninecraft.booket.feature.screens

import com.slack.circuit.runtime.Navigator
import kotlinx.coroutines.delay

suspend fun Navigator.delayedGoTo(screen: ReedScreen, delayMillis: Long = 200L) {
delay(delayMillis)
goTo(screen)
}
Comment on lines +6 to +9
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

임시 해결책으로는 적절하지만 개선 사항을 고려해보세요.

구현 자체는 올바르지만 다음 사항들을 고려해보시기 바랍니다:

  • 200ms 기본 지연 시간이 모든 Dialog/BottomSheet에 적합한지 검증 필요
  • 사용자 경험 관점에서 지연이 체감될 수 있음
  • Circuit의 Overlay 메커니즘을 활용한 더 나은 해결책 검토 권장
🤖 Prompt for AI Agents 
In
feature/screens/src/main/kotlin/com/ninecraft/booket/feature/screens/extensions.kt
around lines 6 to 9, the current delayedGoTo function uses a fixed 200ms delay
which may not suit all Dialogs or BottomSheets and could negatively impact user
experience. Review and validate if the default delay is appropriate for all
cases, and consider replacing this approach by leveraging Circuit's Overlay
mechanism for a more robust and user-friendly navigation delay solution.


suspend fun Navigator.delayedPop(delayMillis: Long = 200L) {
delay(delayMillis)
pop()
}
5 changes: 4 additions & 1 deletion feature/search/src/main/kotlin/com/ninecraft/booket/feature/search/SearchPresenter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import com.ninecraft.booket.core.ui.component.FooterState
import com.ninecraft.booket.feature.screens.LoginScreen
import com.ninecraft.booket.feature.screens.RecordScreen
import com.ninecraft.booket.feature.screens.SearchScreen
import com.ninecraft.booket.feature.screens.delayedGoTo
import com.orhanobut.logger.Logger
import com.slack.circuit.codegen.annotations.CircuitInject
import com.slack.circuit.retained.collectAsRetainedState
Expand Down Expand Up @@ -191,7 +192,9 @@ class SearchPresenter @AssistedInject constructor(

is SearchUiEvent.OnBookRegisterSuccessOkButtonClick -> {
isBookRegisterSuccessBottomSheetVisible = false
navigator.goTo(RecordScreen(registeredUserBookId))
scope.launch {
navigator.delayedGoTo(RecordScreen(registeredUserBookId))
}
}

is SearchUiEvent.OnBookRegisterSuccessCancelButtonClick -> {
Expand Down
Loading