Skip to content

Commit b54efd9

Browse files
committed
[BOOK-268] feat: update LoginView present style
1 parent da6bbe1 commit b54efd9

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

src/Projects/BKPresentation/Sources/AppCoordinator.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ public final class AppCoordinator: Coordinator, AuthenticationRequiredNotifying
5555
onFinishAuth: (() -> Void)?
5656
) {
5757
let authNavigationController = UINavigationController()
58+
authNavigationController.modalPresentationStyle = .fullScreen
59+
authNavigationController.isModalInPresentation = true
5860
let loginCoordinator = LoginCoordinator(
5961
parentCoordinator: self,
6062
navigationController: authNavigationController

src/Projects/BKPresentation/Sources/AuthFlow/View/LoginViewController.swift

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,11 @@ final class LoginViewController: BaseViewController<LoginView> {
1515
override var bkNavigationBarStyle: UINavigationController.BKNavigationBarStyle {
1616
.standard(
1717
viewController: self,
18-
rightButton: .none
18+
rightButton: .init(
19+
image: BKImage.Icon.x,
20+
target: self,
21+
action: #selector(handleCloseButtonTapped)
22+
)
1923
)
2024
}
2125

@@ -28,16 +32,6 @@ final class LoginViewController: BaseViewController<LoginView> {
2832
super.init()
2933
}
3034

31-
override func viewWillAppear(_ animated: Bool) {
32-
super.viewWillAppear(animated)
33-
self.navigationController?.navigationBar.isHidden = true
34-
}
35-
36-
override func viewWillDisappear(_ animated: Bool) {
37-
super.viewWillDisappear(animated)
38-
self.navigationController?.navigationBar.isHidden = false
39-
}
40-
4135
override func bindAction() {
4236
contentView.eventPublisher
4337
.sink { event in
@@ -92,4 +86,8 @@ final class LoginViewController: BaseViewController<LoginView> {
9286
}
9387
.store(in: &cancellable)
9488
}
89+
90+
@objc private func handleCloseButtonTapped() {
91+
self.dismiss(animated: true)
92+
}
9593
}

0 commit comments

Comments
 (0)