Skip to content

Commit f004f05

Browse files
committed
[BOOK-435] fix: 토끼 리뷰 반영
1 parent 07105bf commit f004f05

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

src/Projects/BKPresentation/Sources/AppCoordinator.swift

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ public final class AppCoordinator: Coordinator, AuthenticationRequiredNotifying,
9696
}
9797
else if currentVersion < latestVersion {
9898
self.presentUpdateSheet(isForced: false) // 권장
99-
self.proceedWithAppFlow()
10099
}
101100
else {
102101
self.proceedWithAppFlow()
@@ -229,6 +228,7 @@ public final class AppCoordinator: Coordinator, AuthenticationRequiredNotifying,
229228
)
230229
)
231230
} else {
231+
// TODO(dyk) : 디자인 파트와 논의 후 subtitle 수정하기
232232
dialog = BKDialog(
233233
title: "최신 버전이 출시되었습니다",
234234
subtitle: "최적의 사용 환경을 위해 업데이트해주세요.",
@@ -237,7 +237,10 @@ public final class AppCoordinator: Coordinator, AuthenticationRequiredNotifying,
237237
leftButtonAction: AppStoreLinker.openAppStore,
238238
rightButtonTitle: "나중에 하기",
239239
rightButtonAction: { [weak self] in
240-
self?.navigationController.dismiss(animated: true)
240+
guard let self else { return }
241+
self.navigationController.dismiss(animated: true) {
242+
self.proceedWithAppFlow()
243+
}
241244
}
242245
)
243246
)
@@ -246,9 +249,7 @@ public final class AppCoordinator: Coordinator, AuthenticationRequiredNotifying,
246249
guard let dialog else { return }
247250
let dialogViewController = BKDialogViewController(dialog: dialog)
248251
dialogViewController.isModalInPresentation = true
249-
DispatchQueue.main.async {
250-
self.navigationController.present(dialogViewController, animated: true)
251-
}
252+
navigationController.present(dialogViewController, animated: true)
252253
}
253254

254255
private func requestNotificationPermissionIfNeeded() {

0 commit comments

Comments
 (0)