Skip to content

Feature-detect GLOB_BRACE for musl-libc PHP builds (Alpine, static FrankenPHP) #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
superdav42 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature-detect GLOB_BRACE for musl-libc PHP builds (Alpine, static FrankenPHP) #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions includes/Wpup/UpdateServer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,13 +385,28 @@ protected function findFirstAsset(
) {
$pattern = $this->assetDirectories[$assetType] . '/' . $package->slug . $suffix;

//GLOB_BRACE is not defined on every libc (e.g. musl, used by Alpine/static
//FrankenPHP builds). When it's missing, fall back to one glob() call per
//extension and merge the results. Behaviour is identical otherwise.
if ( is_array($extensions) ) {
$extensionPattern = '{' . implode(',', $extensions) . '}';
if ( defined('GLOB_BRACE') ) {
$assets = glob(
$pattern . '.{' . implode(',', $extensions) . '}',
GLOB_BRACE | GLOB_NOESCAPE
);
} else {
$assets = array();
foreach ($extensions as $extension) {
$matches = glob($pattern . '.' . $extension, GLOB_NOESCAPE);
if ( !empty($matches) ) {
$assets = array_merge($assets, $matches);
}
}
}
} else {
$extensionPattern = $extensions;
$assets = glob($pattern . '.' . $extensions, GLOB_NOESCAPE);
}

$assets = glob($pattern . '.' . $extensionPattern, GLOB_BRACE | GLOB_NOESCAPE);
if ( !empty($assets) ) {
$firstFile = basename(reset($assets));
return $this->generateAssetUrl($assetType, $firstFile);
Expand Down