Merge pull request #51 from YassinLokhat/50-hide-first-empty-password-in-account-view

Hide first empty password in account view

Author: YassinLokhat

GUI/WPF/ViewModels/Controls/AccountViewModel.cs

@@ -53,9 +53,23 @@ public string Password
          }
       }
 
-      public PasswordViewModel[] Passwords => [.. Account.Passwords
-            .OrderByDescending(x => x.Key)
-            .Select(x => new PasswordViewModel(x.Key.ToShortDateString(), x.Value))];
+      public PasswordViewModel[] Passwords
+      {
+         get
+         {
+            PasswordViewModel[] passwords = [.. Account.Passwords
+               .OrderByDescending(x => x.Key)
+               .Select(x => new PasswordViewModel(x.Key.ToShortDateString(), x.Value))];
+
+            if (passwords.Length != 0
+               && string.IsNullOrEmpty(passwords.Last().Password))
+            {
+               passwords = passwords[..(passwords.Length - 1)];
+            }
+
+            return passwords;
+         }
+      }
 
       public Brush NotesBackground => Account.HasChanged(nameof(Notes)) ? DarkMode.ChangedBrush : DarkMode.UnchangedBrush2;
       public string Notes
@@ -147,7 +161,7 @@ public bool PasswordLeaked
                && MainViewModel.Database.Warnings.Any(x => x.WarningType == WarningType.PasswordLeakedWarning
                   && x.Accounts.Contains(Account));
 
-      public string[] IdentifierAutoCompleteList => MainViewModel.User?.Services
+      public static string[] IdentifierAutoCompleteList => MainViewModel.User?.Services
          .SelectMany(x => x.Accounts)
          .SelectMany(x => x.Identifiers)
          .Distinct()

GUI/WPF/Views/Controls/AccountView.xaml.cs

@@ -280,7 +280,7 @@ private void _identifier_TextBox_KeyUp(object sender, KeyEventArgs e)
          if (e.Key is Key.Enter
             or Key.Insert)
          {
-            string? identifier = InsertIdentifierView.InsertIdentifierDialog(_viewModel?.IdentifierAutoCompleteList ?? [], identifier_TB.Text);
+            string? identifier = InsertIdentifierView.InsertIdentifierDialog(AccountViewModel.IdentifierAutoCompleteList ?? [], identifier_TB.Text);
 
             if (string.IsNullOrEmpty(identifier)) return;