Strict "async all the way"

Author: dieter-enns-deepl

Main/Nodes/Functions/AsynchronicityHandling.cs

@@ -113,7 +113,7 @@ internal TypedAsynchronicityHandling(
         ITypeSymbol type,
 
         // dependencies
-        WellKnownTypes wellKnownTypes) : base(ReturnTypeStatus.Ordinary, AsyncAwaitStatus.No)
+        WellKnownTypes wellKnownTypes) : base(ReturnTypeStatus.Ordinary, AsyncAwaitStatus.Yes)
     {
         _type = type;
         _wellKnownTypes = wellKnownTypes;
@@ -175,7 +175,7 @@ internal sealed class VoidAsynchronicityHandling : AsynchronicityHandlingBase
 
     internal VoidAsynchronicityHandling(
         // dependencies
-        WellKnownTypes wellKnownTypes) : base(ReturnTypeStatus.Ordinary, AsyncAwaitStatus.No)
+        WellKnownTypes wellKnownTypes) : base(ReturnTypeStatus.Ordinary, AsyncAwaitStatus.Yes)
     {
         _wellKnownTypes = wellKnownTypes;
         _valueTaskExisting = wellKnownTypes.ValueTask is not null;
@@ -230,7 +230,7 @@ internal SomeTaskAsynchronicityHandling(
         INamedTypeSymbol someTaskType,
 
         // dependencies
-        WellKnownTypes wellKnownTypes) : base(ReturnTypeStatus.Ordinary, AsyncAwaitStatus.No)
+        WellKnownTypes wellKnownTypes) : base(ReturnTypeStatus.Ordinary, AsyncAwaitStatus.Yes)
     {
         _someTaskType = someTaskType;
         ReturnTypeStatus = wellKnownTypes.ValueTask1 is { } valueTaskType &&

Main/Nodes/Ranges/ContainerNode.cs

@@ -190,11 +190,14 @@ public override void Build(PassedContext passedContext)
         }
 
         var asyncCallNodes = new List<IWrappedAsyncFunctionCallNode>();
+        var potentialTaskBasedEntryFunctions = new List<IFunctionNode>();
         while (BuildQueue.Count != 0 && BuildQueue.Dequeue() is { } buildJob)
         {
             buildJob.Node.Build(buildJob.PassedContext);
             if (buildJob.Node is IWrappedAsyncFunctionCallNode call)
                 asyncCallNodes.Add(call);
+            if (buildJob.Node is IFunctionNode function and (IEntryFunctionNode or ILocalFunctionNode))
+                potentialTaskBasedEntryFunctions.Add(function);
         }
 
         _currentExecutionPhaseSetter.Value = ExecutionPhase.ResolutionValidation;
@@ -220,6 +223,13 @@ public override void Build(PassedContext passedContext)
 
         foreach (var delegateBaseNode in _delegateBaseNodes)
             delegateBaseNode.CheckSynchronicity();
+
+        foreach (var potentialTaskBasedEntryFunction in potentialTaskBasedEntryFunctions)
+        {
+            var returnTypeStatus = potentialTaskBasedEntryFunction.ReturnTypeStatus;
+            if (returnTypeStatus.HasFlag(ReturnTypeStatus.Task) || returnTypeStatus.HasFlag(ReturnTypeStatus.ValueTask))
+                potentialTaskBasedEntryFunction.MakeTaskBasedToo();
+        }
     }
 
     public override string? ContainerReference => null;