Detect unquoted password values in C# connection strings#959
Open
Saharsh1123 wants to merge 1 commit into
Open
Detect unquoted password values in C# connection strings#959Saharsh1123 wants to merge 1 commit into
Saharsh1123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
C# connection strings containing an unquoted password field, such as:
are not detected by the keyword plugin.
Fixes #699.
The keyword plugin now detects C# connection-string-style
keyword=value;password fields and extracts the password value.This adds coverage for the reported
Password=svcacctpass;case while preserving existing C / Objective-C behavior that requires quoted values for normal C-style assignments.Does this PR introduce a breaking change?
No.
Other information:
Tested locally with:
python -m pytest tests/plugins/keyword_test.pypython -m pytest testspython -m pytest