fix: Add pnpm-lock.yaml to is_lock_file filter#962
Open
Mallikarjunadevops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 945: is_lock_file does not filter pnpm-lock.yaml
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
is_lock_filefilter ignorespnpm-lock.yaml, leading to false positives inside this lockfile duringdetect-secrets scanoperations. (Fixes #945)What is the new behavior?
Added
'pnpm-lock.yaml'to the set of ignored lock files indetect_secrets/filters/heuristic.py. This ensurespnpmlock files are correctly excluded from scanning, identical toyarn.lockandpackage-lock.json.Does this PR introduce a breaking change?
No
Other information:
Added test case in
tests/filters/heuristic_filter_test.pyto confirmis_lock_file('pnpm-lock.yaml')evaluates to True.Testing Evidence
Pytest completed successfully for all test cases in
tests/filters/heuristic_filter_test.py.