Use kotlinx.serialization instead of moshi#136
Draft
friedger wants to merge 4 commits intoYelp:masterfrom
Draft
Conversation
Collaborator
|
Thanks for the PR @friedger, I think it's a good starting point to have a prototype (though I can't be merged as it's going to be a breaking change). I think the goal could be to have the So far you have ktlint failing. I suggest you to install the pre-commit hooks with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to make the project better suitable for multiplatform projects.
Therefore, moshi is replaced by kotlinx.serialization. Probably, this should go in a different folder or classes.
This is mainly to see what changes need to be done for kotlinx.serialization