Replace moshi with kotlinx-serialization#152
Closed
agologan wants to merge 2 commits intoYelp:masterfrom
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
============================================
- Coverage 71.95% 71.90% -0.05%
Complexity 139 139
============================================
Files 11 11
Lines 574 573 -1
Branches 75 75
============================================
- Hits 413 412 -1
Misses 118 118
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends on #136. There's still work to be so external input is more then welcome:
Changes that should be discussed:
ZonedDateTimewithInstantfrom kotlinx-datetime - while this logically correct it does reduce all datetime representations to Zulu timezonenumberfromBigDecimaltodouble- there is no official kmp support forBigDecimalwhich is not great becausedoubleis an approximationobjectwithJsonObject- while usingJson*classes is more type-safe it does modify the API heavilyAs you can see most problems are around unsupported types which we could support via the Java classes but would still require some serialization changes maybe via contextual serialization?
The last problematic point is regarding nullability. While deserialization works as expected serialization implicitly omits
nullvalues. As far as I can tell these could be added back if the integrator passes inencodeDefaults: true on theJsonConfiguration. Thex-nullablevendor extension just statesnullas a valid value and doesn't imply the client should explicitly sendnullto define a property as missing so maybe this is not actually a problem.