fix: early return

- Remove early exits before EndChild.
- Don't prepend a favorite symbol to the selectable if we're in the favorites tab.

Author: xesdoog

SSV2/includes/frontend/yim_actions/actions_ui.lua

@@ -37,6 +37,7 @@ local t_ActionsSidebarItems <const> = {
 	},
 }
 
+---@type array<fun(): string>
 local SideBarTips <const> = {
 	function() return _F(_T("YAV3_STOP_BTN_HINT"), GVars.keyboard_keybinds.stop_anim) end,
 	function() return _F(_T("YAV3_SYMBOL_DEFS_HINT"), "[*]", "[C]", "[U]") end,
@@ -88,9 +89,9 @@ local function DrawActionsSidebar()
 		GUI:PlaySound(GUI.Sounds.Nav)
 		if (sidebarTipIndex == 1) then
 			sidebarTipIndex = #SideBarTips
-			return
+		else
+			sidebarTipIndex = sidebarTipIndex - 1
 		end
-		sidebarTipIndex = sidebarTipIndex - 1
 	end
 	GUI:Tooltip(_T("GENERIC_PREVIOUS"))
 
@@ -99,9 +100,9 @@ local function DrawActionsSidebar()
 		GUI:PlaySound(GUI.Sounds.Nav)
 		if (sidebarTipIndex == #SideBarTips) then
 			sidebarTipIndex = 1
-			return
+		else
+			sidebarTipIndex = sidebarTipIndex + 1
 		end
-		sidebarTipIndex = sidebarTipIndex + 1
 	end
 	GUI:Tooltip(_T("GENERIC_NEXT"))
 	ImGui.SetWindowFontScale(1.0)

SSV2/includes/services/asset_browsers/ActionBrowser.lua

@@ -406,44 +406,50 @@ function ActionBrowser:DrawItemContext(k, v)
 
 	local current_label = self.m_name_resolver(v)
 	local current_cat   = self.m_category_name
+	local current_mode  = self.m_mode
 	local is_favorite   = YimActions:DoesFavoriteExist(current_cat, current_label)
+	-- local is_user_gen   = current_cat == "anims" and (Backend.debug_mode and YimActions:GetUGA()[current_label] ~= nil) or false -- TODO: Add an option to create new anim defs
 	local has_command   = YimActions.Commands[current_label] ~= nil
 	local indicators    = ""
 
-	if (is_favorite) then
+	if (is_favorite and current_mode.name ~= "favorites") then
 		indicators = indicators .. "[*] "
 	end
 
 	if (has_command) then
 		indicators = indicators .. "[C] "
 	end
 
+	-- if (is_user_gen) then
+	-- 	indicators = indicators .. "[U] "
+	-- end
+
 	local avail     = ImGui.GetContentRegionAvail()
 	local textWidth = ImGui.CalcTextSize(indicators)
 	ImGui.SameLine(avail - textWidth)
 	ImGui.TextDisabled(indicators)
 
 	if (ImGui.BeginPopup(context_label)) then
 		if (is_favorite) then
-			if (self.m_mode.can_remove_favorite and ImGui.MenuItem("Remove From Favorites")) then
+			if (current_mode.can_remove_favorite and ImGui.MenuItem("Remove From Favorites")) then
 				GUI:PlaySound("Click")
 				YimActions:RemoveFromFavorites(current_cat, current_label)
 			end
 		else
-			if (self.m_mode.can_add_favorite and ImGui.MenuItem("Add To Favorites")) then
+			if (current_mode.can_add_favorite and ImGui.MenuItem("Add To Favorites")) then
 				GUI:PlaySound("Click")
 				YimActions:AddToFavorites(current_cat, current_label, v, self.m_type)
 			end
 		end
 
 		if (self.m_type ~= Enums.eActionType.CLIPSET) then
 			if (has_command) then
-				if (self.m_mode.can_remove_command and ImGui.MenuItem("Remove Command")) then
+				if (current_mode.can_remove_command and ImGui.MenuItem("Remove Command")) then
 					GUI:PlaySound("Click")
 					YimActions:RemoveCommandAction(current_label)
 				end
 			else
-				if (self.m_mode.can_add_command and ImGui.MenuItem("Create Command")) then
+				if (current_mode.can_add_command and ImGui.MenuItem("Create Command")) then
 					GUI:PlaySound("Click")
 					YimActions.DrawNewCommandWindow = true
 				end