Skip to content

Commit 861ca63

Browse files
committed
Fixed erroneous extra line added after blockquote
Added test to make sure extra line is not added.
1 parent 46709e9 commit 861ca63

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

src/draft-to-markdown.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -462,8 +462,7 @@ function renderBlock(block, index, rawDraftObject, options) {
462462
markdownString += '\n';
463463
} else if (rawDraftObject.blocks[index + 1]) {
464464
if (rawDraftObject.blocks[index].text) {
465-
if (type === 'blockquote' && options.preserveNewlines
466-
|| SingleNewlineAfterBlock.indexOf(type) !== -1
465+
if (SingleNewlineAfterBlock.indexOf(type) !== -1
467466
&& SingleNewlineAfterBlock.indexOf(rawDraftObject.blocks[index + 1].type) === -1) {
468467
markdownString += '\n\n';
469468
} else if (!options.preserveNewlines) {

test/idempotency.spec.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,13 @@ describe('idempotency', function () {
4343
expect(markdownFromDraft).toEqual(markdownString);
4444
});
4545

46+
it('renders blockquotes correctly', function () {
47+
var markdownString = '> Hello I am Blockquote\n\nI am not\n\n> I am';
48+
var draftJSObject = markdownToDraft(markdownString, {preserveNewlines: true});
49+
var markdownFromDraft = draftToMarkdown(draftJSObject, {preserveNewlines: true});
50+
expect(markdownFromDraft).toEqual(markdownString);
51+
});
52+
4653
it('renders italic text correctly', function () {
4754
var markdownString = '_I am italic_ …I am not italic.';
4855
var draftJSObject = markdownToDraft(markdownString);

0 commit comments

Comments
 (0)