Skip to content

Commit 313499b

Browse files
author
Yogesh Prajapati
committed
fix(release): two bugs in the v1.7.1 build that need a rebuild
1. WINDOWS .ZIP NEVER BUILT release.yml had 'target_flag: --win nsis' which restricted electron-builder to the NSIS target only — the zip target I added in package.json was silently ignored. Changed to '--win' (no specific target), which builds every target listed in build.win.target, so we now get both notepp-win-x64.exe AND notepp-win-x64.zip per release. 2. LINUX FILENAME MISMATCH electron-builder hardcodes Linux arch suffixes per format: AppImage → x86_64 (not x64) deb → amd64 (not x64) even when artifactName explicitly says '${arch}'. My README linked to notepp-linux-x64.AppImage and notepp-linux-x64.deb, which 404'd because the real files are notepp-linux-x86_64.AppImage and notepp-linux-amd64.deb. Updated README badge URL + install table to match what electron-builder actually produces. Now matches the actual asset names from the existing build, so the links work the moment the next rebuild publishes.
1 parent 9d93665 commit 313499b

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,10 @@ jobs:
2424
matrix:
2525
include:
2626
- os: windows-latest
27-
target_flag: --win nsis
27+
target_flag: --win
2828
artifact_glob: |
2929
dist/*.exe
30+
dist/*.zip
3031
dist/latest.yml
3132
dist/*.blockmap
3233
- os: macos-latest

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
[![Ollama](https://img.shields.io/badge/AI-Ollama-000000?logo=ollama&logoColor=white)](https://ollama.com/)
2222
[![Windows](https://img.shields.io/badge/Windows-Download-0078D4?logo=windows&logoColor=white)](https://github.com/YogeshPraj/Note-/releases/latest/download/notepp-win-x64.exe)
2323
[![macOS](https://img.shields.io/badge/macOS-Download-000000?logo=apple&logoColor=white)](https://github.com/YogeshPraj/Note-/releases/latest)
24-
[![Linux](https://img.shields.io/badge/Linux-Download-FCC624?logo=linux&logoColor=black)](https://github.com/YogeshPraj/Note-/releases/latest/download/notepp-linux-x64.AppImage)
24+
[![Linux](https://img.shields.io/badge/Linux-Download-FCC624?logo=linux&logoColor=black)](https://github.com/YogeshPraj/Note-/releases/latest/download/notepp-linux-x86_64.AppImage)
2525

2626
[**📥 Download**](https://github.com/YogeshPraj/Note-/releases/latest)[Quick Start](#-quick-start)[Features](#-features)[Architecture](#-architecture)[Roadmap](#-roadmap)
2727

@@ -169,7 +169,7 @@ Grab the latest installer for your OS from [Releases](https://github.com/YogeshP
169169
| --- | --- |
170170
| **Windows** (x64) | 📦 [Installer (.exe)](https://github.com/YogeshPraj/Note-/releases/latest/download/notepp-win-x64.exe) · 📁 [Portable (.zip)](https://github.com/YogeshPraj/Note-/releases/latest/download/notepp-win-x64.zip) |
171171
| **macOS** | 🍎 [Intel (.dmg)](https://github.com/YogeshPraj/Note-/releases/latest/download/notepp-mac-x64.dmg) · 🍎 [Apple Silicon (.dmg)](https://github.com/YogeshPraj/Note-/releases/latest/download/notepp-mac-arm64.dmg) |
172-
| **Linux** (x64) | 🐧 [Portable (.AppImage)](https://github.com/YogeshPraj/Note-/releases/latest/download/notepp-linux-x64.AppImage) · 🐧 [Debian/Ubuntu (.deb)](https://github.com/YogeshPraj/Note-/releases/latest/download/notepp-linux-x64.deb) |
172+
| **Linux** (x64) | 🐧 [Portable (.AppImage)](https://github.com/YogeshPraj/Note-/releases/latest/download/notepp-linux-x86_64.AppImage) · 🐧 [Debian/Ubuntu (.deb)](https://github.com/YogeshPraj/Note-/releases/latest/download/notepp-linux-amd64.deb) |
173173

174174
Filenames are version-less by design — the actual version is shown in the installer UI, the About dialog, and on the [Releases page](https://github.com/YogeshPraj/Note-/releases) title. You'll also see a handful of `*-mac.zip` / `*.blockmap` / `latest*.yml` files in each release — those are auto-updater payloads, not for manual download.
175175

0 commit comments

Comments
 (0)