Commit 313499b
Yogesh Prajapati
fix(release): two bugs in the v1.7.1 build that need a rebuild
1. WINDOWS .ZIP NEVER BUILT
release.yml had 'target_flag: --win nsis' which restricted
electron-builder to the NSIS target only — the zip target I added
in package.json was silently ignored. Changed to '--win' (no
specific target), which builds every target listed in
build.win.target, so we now get both notepp-win-x64.exe AND
notepp-win-x64.zip per release.
2. LINUX FILENAME MISMATCH
electron-builder hardcodes Linux arch suffixes per format:
AppImage → x86_64 (not x64)
deb → amd64 (not x64)
even when artifactName explicitly says '${arch}'. My README
linked to notepp-linux-x64.AppImage and notepp-linux-x64.deb,
which 404'd because the real files are
notepp-linux-x86_64.AppImage and notepp-linux-amd64.deb.
Updated README badge URL + install table to match what
electron-builder actually produces. Now matches the actual asset
names from the existing build, so the links work the moment the
next rebuild publishes.1 parent 9d93665 commit 313499b
2 files changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
172 | | - | |
| 172 | + | |
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
| |||
0 commit comments