feat: emit public TestMethodIdentifierProperty and stop advertising vstestProvider (#284)

BREAKING-CHANGE: Depending on your version of .NET, this may require setting `test.runner` to `Microsoft.Testing.Platform` in `global.json`.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Evangelink

src/YoloDev.Expecto.TestSdk/TestApplicationHelpers.fs

@@ -2,18 +2,37 @@ namespace YoloDev.Expecto.TestSdk
 
 open System.Reflection
 
-open Microsoft.Testing.Extensions.VSTestBridge.Capabilities
+open Microsoft.Testing.Extensions.TrxReport.Abstractions
 open Microsoft.Testing.Extensions.VSTestBridge.Helpers
 open Microsoft.Testing.Platform.Builder
 open Microsoft.Testing.Platform.Capabilities.TestFramework
 
+// We intentionally do NOT use VSTestBridgeExtensionBaseCapabilities because that type also implements
+// INamedFeatureCapability and advertises the "vstestProvider" capability. When a server advertises
+// vstestProvider, Visual Studio Test Explorer consumes the legacy "vstest.TestCase.*" properties
+// (serialized through Microsoft.Testing.Platform's internal SerializableKeyValuePairStringProperty
+// key/value bag) instead of the public, structured location.* properties.
+//
+// ExpectoTestFramework.AddAdditionalProperties now emits the public TestMethodIdentifierProperty
+// (serialized as location.type / location.method), so by not advertising vstestProvider we let the IDE
+// consume the public properties and stop depending on the internal key/value-pair shape.
+//
+// This mirrors MSTest's MSTestCapabilities:
+// https://github.com/microsoft/testfx/blob/5c6ea3bf01f1247736fbbbba0ffdd8a8b38840dc/src/Adapter/MSTest.TestAdapter/TestingPlatformAdapter/TestApplicationBuilderExtensions.cs
+// MSTest can implement the internal IInternalVSTestBridgeTrxReportCapability (it is on the bridge's
+// InternalsVisibleTo list); external adapters cannot, so we implement the public ITrxReportCapability.
+type internal ExpectoTestFrameworkCapabilities() =
+  interface ITrxReportCapability with
+    member _.IsSupported = true
+    member _.Enable() = ()
+
 module TestApplicationBuilderExtensions =
   let addExpectoFramework (getTestAssemblies: unit -> Assembly seq) (builder: ITestApplicationBuilder) =
     let expectoExtension = ExpectoExtension()
     builder.AddRunSettingsService expectoExtension
     builder.AddTestCaseFilterService expectoExtension
     builder.RegisterTestFramework (
-      (fun _ -> TestFrameworkCapabilities(VSTestBridgeExtensionBaseCapabilities())),
+      (fun _ -> TestFrameworkCapabilities(ExpectoTestFrameworkCapabilities())),
       (fun capabilities serviceProvider -> new ExpectoTestFramework(expectoExtension, getTestAssemblies, serviceProvider, capabilities))
     ) |> ignore
 

src/YoloDev.Expecto.TestSdk/adapter.fs

@@ -5,6 +5,7 @@ open System.Threading
 open System.Diagnostics
 open Microsoft.Testing.Extensions.VSTestBridge
 open Microsoft.Testing.Extensions.VSTestBridge.Requests
+open Microsoft.Testing.Platform.Extensions.Messages
 open Microsoft.VisualStudio.TestPlatform.ObjectModel
 open Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter
 open System.Threading.Tasks
@@ -128,3 +129,23 @@ type ExpectoTestFramework(extension, getTestAssemblies, serviceProvider, capabil
 
   override _.SynchronizedDiscoverTestsAsync(request, _, _) = discoverTests request
   override _.SynchronizedRunTestsAsync(request, _, token) = runTests request token
+
+  // Expecto tests are values in nested test lists, not CLR methods, so there is no real managed
+  // type/method. We synthesize a public TestMethodIdentifierProperty from the (dot-joined)
+  // FullyQualifiedName so Visual Studio can recover namespace/class/method via location.type /
+  // location.method without the legacy vstest.TestCase.* key/value-pair properties.
+  // NOTE: this assumes the default `--join-with .` separator; per-row identity relies on TestNode.Uid.
+  override _.AddAdditionalProperties(testNode: TestNode, testCase: TestCase) =
+    let fqn = testCase.FullyQualifiedName
+    if not (System.String.IsNullOrEmpty fqn) then
+      let lastDot = fqn.LastIndexOf '.'
+      let typeName, methodName =
+        if lastDot > 0 then fqn.Substring(0, lastDot), fqn.Substring(lastDot + 1)
+        else "", fqn
+      let assemblyFullName =
+        try AssemblyName.GetAssemblyName(testCase.Source).FullName
+        with _ -> ""
+      let property =
+        TestMethodIdentifierProperty(
+          assemblyFullName, "", typeName, methodName, 0, Array.empty<string>, "System.Void")
+      testNode.Properties.Add property

src/YoloDev.Expecto.TestSdk/execution.fs

@@ -80,8 +80,13 @@ module private PrinterAdapter =
       result.Outcome <- TestOutcome.Skipped
       result.EndTime <- DateTimeOffset.Now
 
-      result.Messages.Add
-      <| TestResultMessage(TestResultMessage.AdditionalInfoCategory, sprintf "Skipped: %s" reason)
+      // Surface the skip reason via ErrorMessage rather than a TestResultMessage with
+      // AdditionalInfoCategory. The Microsoft.Testing.Platform VSTest bridge only knows how to
+      // convert StandardError/StandardOut/DebugTrace message categories when building the TRX
+      // report and throws UnreachableException on any other category, so an AdditionalInfo message
+      // crashes the MTP run. For skipped tests the bridge maps ErrorMessage to
+      // SkippedTestNodeStateProperty, and the legacy VSTest runner also shows it as the skip reason.
+      result.ErrorMessage <- sprintf "Skipped: %s" reason
 
       recordEnd result