Fix nullability error in CI build#296
Open
farlee2121 wants to merge 4 commits into
Open
Conversation
…ead of a positional argument. Seems to be an Microsoft.Testing.Platform thing
Guard.argNotNull was returning the original value, so the compiler thought the return value could still be null. Now the compiler recognizes that the return value cannot be null
Contributor
|
Thanks. I'll try to re-create the error from earlier and double check if this fixes it :). Or if I'm able to set up a test-matrix with different expecto versions that would be even better. Hopefully I'll get to this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responding to #291 (comment)
I recreated the update to expecto 11, and it passes with these changes.
It appears the issue was argNotNull was returning the original value instead of the pattern matched value, which confused the compiler into thinking the value might still be null