Skip to content

Library prints devtools error message to console #99

@wearhere

Description

@wearhere

If this library is loaded without react-devtools-core or ws being installed, https://github.com/Yomguithereal/react-blessed/blob/1ae620a62c90bd34051d6458876a6b70abd7cf77/src/fiber/devtools.js will throw an error, resulting in this message being logged to the console. I see that I can suppress that by setting NODE_ENV = 'production' prior to loading this library. Is that your recommendation for clients? I don't see anything in the README about that, would be nice to add.

Alternatively, it might be nice to only log this message at all for developers of react-blessed, e.g. compile that warning out, maybe not even try to require('./devtools'), when you build react-blessed for distribution.

If you intend for clients (not just yourselves) to be able to use the devtools, then it would be nice to document that in the README, and IMO make clients have to opt-into using react-devtools / seeing that warning, rather than, at present, have to set NODE_ENV to suppress the warning.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions