Fix for colors

deto · deto · commit d1f7873d6832 · 2020-02-06T12:05:33.000-08:00
diff --git a/inst/html_output/src/ColorScatterPlotly.js b/inst/html_output/src/ColorScatterPlotly.js
@@ -108,8 +108,12 @@ ColorScatter.prototype.setData = function(object)
             var marker = {
                 size: circle_radius
             }
-            if (unique.length > 10) {
-                var hue = Math.round(i/unique.length * 360);
+            if (unique.length > 10) { // Use husl if more than 10 categories
+                var step = 8
+                var L = Math.ceil(unique.length/step)*step
+                var hue = Math.round(
+                    ( (i*L/step)%L + Math.floor(i/step) ) / L * 360 // Helps scatter values
+                );
                 marker['color'] = hsluv.hsluvToHex([hue, 90, 55])
             }
 

Original file line number	Diff line number	Diff line change
`@@ -108,8 +108,12 @@ ColorScatter.prototype.setData = function(object)`
`108`	`108`	`var marker = {`
`109`	`109`	`size: circle_radius`
`110`	`110`	`}`
`111`		`- if (unique.length > 10) {`
`112`		`- var hue = Math.round(i/unique.length * 360);`
	`111`	`+ if (unique.length > 10) { // Use husl if more than 10 categories`
	`112`	`+ var step = 8`
	`113`	`+ var L = Math.ceil(unique.length/step)*step`
	`114`	`+ var hue = Math.round(`
	`115`	`+ ( (iL/step)%L + Math.floor(i/step) ) / L 360 // Helps scatter values`
	`116`	`+ );`
`113`	`117`	`marker['color'] = hsluv.hsluvToHex([hue, 90, 55])`
`114`	`118`	`}`
`115`	`119`