feat: Fix device info more-data page count#502
Merged
DennisDyallo merged 7 commits intoJul 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Core device-info discovery to treat the device-info “more data” TLV (TAG_MORE_DATA / 0x10) as a remaining page count (instead of a boolean), and adds regression tests across SmartCard, FIDO HID, and OTP HID transports to lock in the corrected semantics.
Changes:
- Interpret
TAG_MORE_DATAvalue as “remaining pages” and skip/Dispose that TLV before parsing device info. - Add SmartCard + FIDO HID + OTP HID unit tests validating remaining-page-count behavior and requested page sequence tracking.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Core/src/Devices/DeviceInfoReader.cs |
Updates multi-page read loop to use remaining-page count semantics and exclude the “more data” TLV from device-info parsing. |
src/Core/tests/Yubico.YubiKit.Core.UnitTests/Devices/DeviceInfoReaderTests.cs |
Adds regression coverage for remaining-page-count semantics across transports (including OTP requested-page tracking). |
Base automatically changed from
yubikit-performance
to
yubikit-composite-device-new
July 1, 2026 10:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification