feat: Validate CTAPHID response framing#504
Merged
DennisDyallo merged 6 commits intoJul 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens CTAP HID response parsing in FidoHidProtocol by validating response framing (channel IDs, init/continuation packet type, and continuation sequence), and adds unit tests to exercise these framing validation paths.
Changes:
- Added validation for CTAP HID init response packets (minimum length, channel ID match, init bit set).
- Added validation for CTAP HID continuation packets (minimum length, channel ID match, init bit clear, expected sequence with 7-bit semantics).
- Introduced new unit tests covering channel/sequence mismatches, malformed short init packets, and init-vs-continuation framing errors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Core/src/Protocols/Fido/Hid/FidoHidProtocol.cs | Adds init/continuation response framing validation and keep-alive handling adjustments during response receive. |
| src/Core/tests/Yubico.YubiKit.Core.UnitTests/Protocols/Fido/Hid/FidoHidProtocolTests.cs | Adds unit tests validating continuation sequence masking and various malformed/incorrect response framing cases. |
Base automatically changed from
yubikit-performance
to
yubikit-composite-device-new
July 1, 2026 10:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification