Fix regeneration of RegistrationTestData.assertion#432
Merged
Conversation
This was broken in commit 8474644 because the `copy` method is no longer used, so `this.assertion` is no longer copied into `newValue`, and therefore `newValue.assertion` is always `None` in this `.map` call. The fix is to call `.map` on `this.assertion` (which is still the old value, which may be `Some`) instead of on `newValue.assertion` (which is always `None`).
Test Results2 271 tests 2 263 ✅ 1m 0s ⏱️ Results for commit e92f7ec. |
fdennis
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken in commit 8474644 because the
copymethod is no longer used, sothis.assertionis no longer copied intonewValue, and thereforenewValue.assertionis alwaysNonein this.mapcall. The fix is to call.maponthis.assertion(which is still the old value, which may beSome) instead of onnewValue.assertion(which is alwaysNone).