Skip to content

Fix integration test #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emlun merged 3 commits into from
May 18, 2026
Merged

Fix integration test #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cf1967
Don't wrap unexpected exceptions in FidoMetadataDownloaderIntegration…
emlun May 12, 2026
a81cbab
Also create parent directories of integration test FIDO_MDS_CACHE_DIR
emlun May 12, 2026
b2b1b18
Declare FIDO_MDS_CACHE_DIR as input dependency of integrationTest task
emlun May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion webauthn-server-attestation/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ val integrationTest = task<Test>("integrationTest") {
classpath = sourceSets["integrationTest"].runtimeClasspath
shouldRunAfter(tasks.test)
val mdsCacheDir = project.layout.buildDirectory.dir("fido-mds-cache").get().asFile
mdsCacheDir.mkdir()
mdsCacheDir.mkdirs()
environment("FIDO_MDS_CACHE_DIR", mdsCacheDir.absolutePath)
inputs.dir(mdsCacheDir)
}
tasks["check"].dependsOn(integrationTest)

Expand Down
16 changes: 6 additions & 10 deletions ...ntegrationTest/scala/com/yubico/fido/metadata/FidoMetadataDownloaderIntegrationTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ import org.scalatest.tags.Slow
import org.scalatestplus.junit.JUnitRunner

import scala.jdk.CollectionConverters.ListHasAsScala
import scala.util.Success
import scala.util.Try

@Slow
@Network
Expand All @@ -28,16 +26,15 @@ class FidoMetadataDownloaderIntegrationTest
val downloader = cachedDefaultSettingsDownloader.build()

it("downloads and verifies the root cert and BLOB successfully.") {
val blob = Try(TestCaches.cacheSynchronized(downloader.loadCachedBlob))
blob shouldBe a[Success[_]]
blob.get should not be null
val blob = TestCaches.cacheSynchronized(downloader.loadCachedBlob)
blob should not be null
}

it(
"does not encounter any CRLDistributionPoints entries in unknown format."
) {
val blob = Try(TestCaches.cacheSynchronized(downloader.loadCachedBlob))
blob shouldBe a[Success[_]]
val blob = TestCaches.cacheSynchronized(downloader.loadCachedBlob)
blob should not be null
val trustRootCert =
CertificateParser.parseDer(
TestCaches.trustRootCache.get.getBytes
Expand Down Expand Up @@ -86,9 +83,8 @@ class FidoMetadataDownloaderIntegrationTest
.build()

it("downloads and parses the BLOB successfully.") {
val blob = Try(TestCaches.cacheSynchronized(downloader.loadCachedBlob))
blob shouldBe a[Success[_]]
blob.get should not be null
val blob = TestCaches.cacheSynchronized(downloader.loadCachedBlob)
blob should not be null
}
}

Expand Down
Loading