fix edge case in algebraic number comparison#9498
Open
ValentinPromies wants to merge 1 commit into
Open
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far,
algebraic_numbers compare_corehandles an edge case incorrectly:a,b) are different,cell_b->m_p), e.g. they are the first and second rootthen the method would return
sign_zero(i.e. "equal"). This behavior can be replicated with the provided test case (before the fix). This requiresalgebraic.factor=false, though i first encountered it during solver runs on QF_NRA instances with the defaultalgebraic.factor=true, which apparently means that the polynomials for anums are still not always factored.The fix is to compare the interval bounds of b to a and vice versa. Then the Sturm-Tarski check is only run if
aandbboth lie in the intersection of the intervals, because only then is it guaranteed to be correct.