Skip to content

Commit fac06eb

Browse files
committed
Fix cask template style offenses to unblock S3 Homebrew publish
S3's "Verify rendered cask + formula against a temp tap" step runs brew style, which flagged 6 offenses in the rendered cask (run 28521485597). Homebrew's cops tightened since the template was written and 3.1.0 was the first release to hit them: - Cask/Desc: desc "Git-Same-Badges" started with the cask name (and was wrong); reuse the CLI formula's description. - Homebrew/OSDependsOn: depends_on macos: ">= :ventura" -> :ventura. - Cask/StanzaGrouping: drop the blank line between app and binary. - Cask/ArrayAlphabetization: order the uninstall delete: and zap trash: arrays (daemon before monitor). - Layout/HashAlignment: align the uninstall delete: bracket. Validated locally against the real 3.1.0 release SHAs via toolkit/homebrew/verify-tap.sh: brew style and brew audit --strict --online now pass for both cask and formula. S2 itself succeeded; only the Homebrew tap publish was blocked.
1 parent 8695e6b commit fac06eb

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

toolkit/homebrew/cask.rb.tmpl

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,17 @@ cask "git-same" do
1313

1414
url "https://github.com/zaai-com/git-same/releases/download/#{version}/git-same-#{version}-#{arch}.dmg"
1515
name "Git-Same"
16-
desc "Git-Same-Badges"
16+
desc "Discover and mirror GitHub org/repo structures locally"
1717
homepage "https://github.com/zaai-com/git-same"
1818

1919
livecheck do
2020
url :url
2121
strategy :github_latest
2222
end
2323

24-
depends_on macos: ">= :ventura"
24+
depends_on macos: :ventura
2525

2626
app "Git-Same.app"
27-
2827
binary "#{appdir}/Git-Same.app/Contents/Helpers/git-same"
2928
binary "#{appdir}/Git-Same.app/Contents/Helpers/git-same", target: "gitsame"
3029
binary "#{appdir}/Git-Same.app/Contents/Helpers/git-same", target: "gitsa"
@@ -62,9 +61,9 @@ cask "git-same" do
6261
# need the legacy label so launchctl unloads the old plist before the new
6362
# one is installed.
6463
uninstall launchctl: ["com.zaai.git-same.monitor", "com.zaai.git-same.daemon"],
65-
delete: [
66-
"~/Library/LaunchAgents/com.zaai.git-same.monitor.plist",
64+
delete: [
6765
"~/Library/LaunchAgents/com.zaai.git-same.daemon.plist",
66+
"~/Library/LaunchAgents/com.zaai.git-same.monitor.plist",
6867
]
6968

7069
zap trash: [
@@ -73,7 +72,7 @@ cask "git-same" do
7372
"~/Library/Caches/com.zaai.git-same",
7473
"~/Library/Caches/git-same",
7574
"~/Library/Group Containers/group.57KL6Y7V32.com.zaai.git-same",
76-
"~/Library/LaunchAgents/com.zaai.git-same.monitor.plist",
7775
"~/Library/LaunchAgents/com.zaai.git-same.daemon.plist",
76+
"~/Library/LaunchAgents/com.zaai.git-same.monitor.plist",
7877
]
7978
end

0 commit comments

Comments
 (0)