This repository was archived by the owner on Jul 3, 2020. It is now read-only.
Added config option for authorization service instead of hard-coded one#395
Open
svycka wants to merge 1 commit into
Open
Added config option for authorization service instead of hard-coded one#395svycka wants to merge 1 commit into
svycka wants to merge 1 commit into
Conversation
Collaborator
|
we probably should migrate to laminas and get rid of zend* deps. @basz, thoughts? |
Contributor
Author
|
@prolic even if you migrate, this would still be useful don't you think? Anyway, having this hardcoded was bad idea in the first place. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are problems with migration to laminas I can't change
Zend\Authentication\AuthenticationServicetoLaminas\Authentication\AuthenticationServicethen I add an alias in service manager for this but in some cases, I can't use this workaround and would be nice if this would be not hardcoded.
now you can just add to config this
This is not a BC break because default still is
Zend\Authentication\AuthenticationService