Skip to content
This repository was archived by the owner on Jul 3, 2020. It is now read-only.

Added config option for authorization service instead of hard-coded one#395

Open
svycka wants to merge 1 commit into
ZF-Commons:masterfrom
svycka:hardcoded-authorization-service
Open

Added config option for authorization service instead of hard-coded one#395
svycka wants to merge 1 commit into
ZF-Commons:masterfrom
svycka:hardcoded-authorization-service

Conversation

@svycka
Copy link
Copy Markdown
Contributor

@svycka svycka commented May 7, 2020

There are problems with migration to laminas I can't change Zend\Authentication\AuthenticationService to Laminas\Authentication\AuthenticationService
then I add an alias in service manager for this but in some cases, I can't use this workaround and would be nice if this would be not hardcoded.
now you can just add to config this

'zfc_rbac' => [
  'authentication_service' => 'Laminas\Authentication\AuthenticationService' // or 'zfcuser_auth_service' in case of zfcUser
];

This is not a BC break because default still is Zend\Authentication\AuthenticationService

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.5%) to 93.443% when pulling a103d30 on svycka:hardcoded-authorization-service into 8a28d65 on ZF-Commons:master.

@prolic
Copy link
Copy Markdown
Collaborator

prolic commented May 7, 2020

we probably should migrate to laminas and get rid of zend* deps. @basz, thoughts?

@svycka
Copy link
Copy Markdown
Contributor Author

svycka commented May 8, 2020

@prolic even if you migrate, this would still be useful don't you think? Anyway, having this hardcoded was bad idea in the first place.

@basz
Copy link
Copy Markdown
Collaborator

basz commented May 8, 2020

I agree with @svycka . this should be merged regardless of the state of #392 or #393

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants