Skip to content

Commit 34f50fb

Browse files
authored
fix: prevent page overflow beneath footer (#199)
1 parent 8be45f4 commit 34f50fb

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

scripts/bundle.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
const esbuild = require("esbuild");
2+
const path = require("path");
23

34
esbuild.build({
4-
entryPoints: ["src/scripts.js"],
5+
entryPoints: [path.join(__dirname, "..", "src", "scripts.js")],
56
bundle: true,
6-
outfile: "dist/bundle.js",
7+
outfile: path.join(__dirname, "..", "dist", "bundle.js"),
78
platform: "browser",
8-
}).catch(() => process.exit(1));
9+
}).catch(() => process.exit(1));

src/styles/components/workarea.css

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@
1414
position: relative;
1515
width: 80%;
1616
max-width: 900px;
17-
height: calc(100vh - 120px);
17+
/* Size against the flex-managed app container so the footer and header are
18+
always accounted for, regardless of window size or toolbar height. */
19+
height: 100%;
1820
background: var(--editor-bg);
1921
color: var(--editor-text);
2022
display: flex;
2123
flex-direction: column;
2224
min-height: 0;
2325
overflow: hidden; /* bubble never scrolls */
24-
}
26+
}

0 commit comments

Comments
 (0)