Skip to content

Commit 72a18eb

Browse files
Fix output order from FW v0.6
1 parent 11261ff commit 72a18eb

2 files changed

Lines changed: 14 additions & 3 deletions

File tree

src/fw_methods.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ end
4040

4141
function FrankWolfe.compute_extreme_point(lmo::AlternatingSeparableLMO{T, N}, dir::AbstractArray{T, N}; kwargs...) where {T <: Real, N}
4242
lmo.fwdata.lmo_counts[1] += 1
43-
if lmo.parallelism
43+
if lmo.parallelism
4444
tensors = [ntuple(n -> Vector{T}(undef, lmo.dims[n]^2), Val(N)) for _ in 1:lmo.nb]
4545
objs = [typemax(T) for _ in 1:lmo.nb]
4646
threaded_foreach(lmo.nb) do tid, task

src/separable_distance.jl

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ function separable_distance(
111111
callback = build_callback(trajectory_arr, epsilon, max_active, shortcut, shortcut_scale, noise_mixture, rp, noise_atol, noise_update_count, C, noise, verbose, logfile, callback_iter)
112112

113113
if fw_algorithm in [FrankWolfe.frank_wolfe, FrankWolfe.lazified_conditional_gradient]
114-
x, v, primal, dual_gap, traj_data = fw_algorithm(
114+
res = fw_algorithm(
115115
f,
116116
grad!,
117117
lmo,
@@ -123,9 +123,14 @@ function separable_distance(
123123
verbose = false,
124124
kwargs...
125125
)
126+
x = res.x
127+
v = res.v
128+
primal = res.primal
129+
dual_gap = res.dual_gap
130+
traj_data = res.traj_data
126131
active_set = FrankWolfe.ActiveSetQuadraticProductCaching([(one(T), x)], LA.I, -C)
127132
else
128-
x, v, primal, dual_gap, traj_data, active_set = fw_algorithm(
133+
res = fw_algorithm(
129134
f,
130135
grad!,
131136
lmo,
@@ -138,6 +143,12 @@ function separable_distance(
138143
lazy,
139144
kwargs...
140145
)
146+
x = res.x
147+
v = res.v
148+
primal = res.primal
149+
dual_gap = res.dual_gap
150+
traj_data = res.traj_data
151+
active_set = res.active_set
141152
end
142153

143154
# print last iteration

0 commit comments

Comments
 (0)