quic需要显示的设置UDP buff, 否则工作不正常#289
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@alexliyu7352 看了下pr的内容 感觉没啥问题 还有要更新的吗 我合入了？ |
Member
Author
@xia-chu 我根据AI review进行了几轮兼容性改进, 并针对的做了测试, 感觉没什么问题, 只是性能下降了不到1.5%, 主要是你要看看向下兼容性, 是否会影响到zlmediakit. 抱歉现在才回, 最近被公司送去参加一个全公司内部的培训去了, 安排的活动太满了. 一直没时间处理自己的事情. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_udpEchoServer + test_udpLantencyClient 3 轮对照后：
- 当前：2250 / 2238 / 2274 ms
- 父提交：2344 / 2379 / 2186 ms
- 均值：
- 当前 2254.0 ms
- 父提交 2303.0 ms
- 当前相对父提交 -2.13%
性能稍微有点影响, 现在最终收口后应该语义上不会对现有链路产生影响. 相比第一个提交, 我改进了使用方式.
并且由于增加了公开函数, 所以做了一些验证限制.避免被误用. 另外一个忘记过滤也提交的宏定义也做了兼容处理