fix: iterative DB upgrade chain and TXT/CAA quote-stripping on ingress

handleDBUpgrades now loops through all pending versions rather than
returning after a single step, so a v0 database correctly runs both
handleDBUpgradeTo1 and handleDBUpgradeTo2 before reaching DBVersion 2.

stripOuterQuotes() removes any surrounding double-quotes from TXT/CAA
values before storage, ensuring the DB always holds raw string content.
answerManaged already re-wraps values at serve time, so submitting a
pre-quoted value (e.g. '"token"') no longer results in corrupt wire data.

Author: ZPascal

api.go

@@ -25,6 +25,15 @@ func toFQDN(name string) string {
 	return name
 }
 
+// stripOuterQuotes removes a single layer of surrounding double-quotes from TXT/CAA values
+// so the DB always stores the raw string content regardless of how the caller supplied it.
+func stripOuterQuotes(value string) string {
+	if len(value) >= 2 && value[0] == '"' && value[len(value)-1] == '"' {
+		return value[1 : len(value)-1]
+	}
+	return value
+}
+
 // probeRR validates that rtype+value form a parseable DNS RR using a placeholder name and TTL.
 func probeRR(rtype, value string) bool {
 	if rtype == "TXT" || rtype == "CAA" {
@@ -223,7 +232,7 @@ func adminCreateRecord(w http.ResponseWriter, r *http.Request, _ httprouter.Para
 		ID:      uuid.New().String(),
 		Name:    toFQDN(req.Name),
 		Type:    req.Type,
-		Value:   req.Value,
+		Value:   stripOuterQuotes(req.Value),
 		TTL:     ttl,
 		Created: time.Now().Unix(),
 	}
@@ -282,7 +291,7 @@ func adminUpdateRecord(w http.ResponseWriter, r *http.Request, ps httprouter.Par
 	if ttl == 0 {
 		ttl = 300
 	}
-	rec := DNSRecord{ID: id, Name: toFQDN(req.Name), Type: req.Type, Value: req.Value, TTL: ttl}
+	rec := DNSRecord{ID: id, Name: toFQDN(req.Name), Type: req.Type, Value: stripOuterQuotes(req.Value), TTL: ttl}
 	if err := DB.UpdateRecord(rec); err != nil {
 		w.Header().Set("Content-Type", "application/json")
 		if errors.Is(err, sql.ErrNoRows) {

api_test.go

@@ -630,6 +630,22 @@ func TestAdminCreateRecordInvalidMXValue(t *testing.T) {
 		Expect().Status(http.StatusBadRequest)
 }
 
+func TestAdminTXTValueQuoteStripping(t *testing.T) {
+	_, e := setupAdminRouter(t, "test-token")
+	// Value submitted with surrounding quotes should be stored and returned without them.
+	payload := map[string]interface{}{
+		"name":  "txt.example.com",
+		"type":  "TXT",
+		"value": `"some token"`,
+		"ttl":   60,
+	}
+	obj := e.POST("/admin/records").
+		WithHeader("Authorization", "Bearer test-token").
+		WithJSON(payload).
+		Expect().Status(http.StatusCreated).JSON().Object()
+	obj.Value("value").String().Equal("some token")
+}
+
 func TestAdminListRecordsFilter(t *testing.T) {
 	_, e := setupAdminRouter(t, "test-token")
 	// Create an A record and a CNAME record

db.go

@@ -101,7 +101,7 @@ func (d *acmedb) Init(engine string, connection string) error {
 	}
 	if err == nil {
 		if versionString == "0" {
-			// No errors so we should now be in version 1
+		// No errors so we should now be in the current version
 			insversion := fmt.Sprintf("INSERT INTO acmedns (Name, Value) values('db_version', '%d')", DBVersion)
 			_, err = db.Exec(insversion)
 		}
@@ -123,11 +123,20 @@ func (d *acmedb) checkDBUpgrades(versionString string) error {
 }
 
 func (d *acmedb) handleDBUpgrades(version int) error {
-	if version == 0 {
-		return d.handleDBUpgradeTo1()
-	}
-	if version == 1 {
-		return d.handleDBUpgradeTo2()
+	for version < DBVersion {
+		var err error
+		switch version {
+		case 0:
+			err = d.handleDBUpgradeTo1()
+		case 1:
+			err = d.handleDBUpgradeTo2()
+		default:
+			return nil
+		}
+		if err != nil {
+			return err
+		}
+		version++
 	}
 	return nil
 }