Fix some issues

* fix some things that I noticed went wrong during rebase
* prefer `List.of()` over `Arrays.asList()` for single object
* Fix `assertThat()` actually asserting in integration test

Author: jorbaum

cloudfoundry-client-reactor/src/main/java/org/cloudfoundry/reactor/tokenprovider/AbstractUaaTokenProvider.java

@@ -74,7 +74,7 @@ public abstract class AbstractUaaTokenProvider implements TokenProvider {
 
     private static final ZoneId UTC = ZoneId.of("UTC");
 
-    protected final ConcurrentMap<ConnectionContext, Mono<String>> accessTokens =
+    private final ConcurrentMap<ConnectionContext, Mono<String>> accessTokens =
             new ConcurrentHashMap<>(1);
 
     private final ConcurrentMap<ConnectionContext, RefreshToken> refreshTokenStreams =

cloudfoundry-client-reactor/src/main/java/org/cloudfoundry/reactor/tokenprovider/_ClientCredentialsGrantTokenProvider.java

@@ -16,7 +16,6 @@
 
 package org.cloudfoundry.reactor.tokenprovider;
 
-import org.cloudfoundry.reactor.ConnectionContext;
 import org.cloudfoundry.reactor.TokenProvider;
 import org.immutables.value.Value;
 import reactor.netty.http.client.HttpClientForm;
@@ -36,10 +35,4 @@ void tokenRequestTransformer(HttpClientRequest request, HttpClientForm form) {
             .attr("grant_type", "client_credentials")
             .attr("response_type", "token");
     }
-
-    @Override
-    public void invalidate(ConnectionContext connectionContext) {
-        this.accessTokens.remove(connectionContext);
-    }
-
 }

cloudfoundry-operations/src/test/java/org/cloudfoundry/operations/applications/DefaultApplicationsTest.java

@@ -33,6 +33,7 @@
 import java.util.Collections;
 import java.util.Date;
 import java.util.LinkedList;
+import java.util.List;
 import java.util.Map;
 import java.util.Optional;
 import java.util.Queue;
@@ -144,6 +145,7 @@
 import org.cloudfoundry.doppler.LogMessage;
 import org.cloudfoundry.doppler.RecentLogsRequest;
 import org.cloudfoundry.doppler.StreamRequest;
+import org.cloudfoundry.logcache.v1.Envelope;
 import org.cloudfoundry.logcache.v1.EnvelopeBatch;
 import org.cloudfoundry.logcache.v1.Log;
 import org.cloudfoundry.logcache.v1.LogCacheClient;
@@ -5105,11 +5107,8 @@ private static void requestLogsRecentLogCache(
                                         .envelopes(
                                                 fill(EnvelopeBatch.builder())
                                                         .batch(
-                                                                Arrays.asList(
-                                                                        fill(org.cloudfoundry
-                                                                                        .logcache.v1
-                                                                                        .Envelope
-                                                                                        .builder())
+                                                                List.of(
+                                                                        fill(Envelope.builder())
                                                                                 .log(
                                                                                         Log
                                                                                                 .builder()

integration-test/src/test/java/org/cloudfoundry/operations/ApplicationsTest.java

@@ -529,7 +529,8 @@ public void logs() throws IOException {
                         this.cloudFoundryOperations
                                 .applications()
                                 .logs(
-                                        ApplicationLogsRequest.builder()
+                                        ApplicationLogsRequest
+                                                .builder()
                                                 .name(applicationName)
                                                 .recent(true)
                                                 .build()))
@@ -2205,7 +2206,7 @@ private static Mono<String> getAppGuidFromAppName(
     }
 
     private static Log checkOneLogEntry(Log log) {
-        assertThat(log.getType().equals(LogType.OUT));
+        assertThat(log.getType()).isEqualTo(LogType.OUT);
         OperationsLogging.log("one log entry: " + log.getType() + " " + log.getPayloadAsText());
         return log;
     }