Skip to content

Commit efaf370

Browse files
committed
Fix some issues
* prefer `List.of()` over `Arrays.asList()` for single object * Fix `assertThat()` actually asserting in integration test
1 parent b39e647 commit efaf370

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

cloudfoundry-operations/src/test/java/org/cloudfoundry/operations/applications/DefaultApplicationsTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import java.util.Collections;
3434
import java.util.Date;
3535
import java.util.LinkedList;
36+
import java.util.List;
3637
import java.util.Map;
3738
import java.util.Optional;
3839
import java.util.Queue;
@@ -144,6 +145,7 @@
144145
import org.cloudfoundry.doppler.LogMessage;
145146
import org.cloudfoundry.doppler.RecentLogsRequest;
146147
import org.cloudfoundry.doppler.StreamRequest;
148+
import org.cloudfoundry.logcache.v1.Envelope;
147149
import org.cloudfoundry.logcache.v1.EnvelopeBatch;
148150
import org.cloudfoundry.logcache.v1.Log;
149151
import org.cloudfoundry.logcache.v1.LogCacheClient;
@@ -5105,11 +5107,8 @@ private static void requestLogsRecentLogCache(
51055107
.envelopes(
51065108
fill(EnvelopeBatch.builder())
51075109
.batch(
5108-
Arrays.asList(
5109-
fill(org.cloudfoundry
5110-
.logcache.v1
5111-
.Envelope
5112-
.builder())
5110+
List.of(
5111+
fill(Envelope.builder())
51135112
.log(
51145113
Log
51155114
.builder()

integration-test/src/test/java/org/cloudfoundry/operations/ApplicationsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2205,7 +2205,7 @@ private static Mono<String> getAppGuidFromAppName(
22052205
}
22062206

22072207
private static Log checkOneLogEntry(Log log) {
2208-
assertThat(log.getType().equals(LogType.OUT));
2208+
assertThat(log.getType()).isEqualTo(LogType.OUT);
22092209
OperationsLogging.log("one log entry: " + log.getType() + " " + log.getPayloadAsText());
22102210
return log;
22112211
}

0 commit comments

Comments
 (0)