Skip to content

Fix Route: make fields optional and omit nulls in notification policy payload#149

Draft
Copilot wants to merge 5 commits into
mainfrom
copilot/update-notification-policy-handler
Draft

Fix Route: make fields optional and omit nulls in notification policy payload#149
Copilot wants to merge 5 commits into
mainfrom
copilot/update-notification-policy-handler

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 22, 2026

  • Replace if-chain in _create_alert_route_dictionary with a dict-comprehension filter (matches existing code style like _create_alert_rule_dictionary)
  • Update integration tests: fix Route(...) calls still using old positional argument order
  • All 58 unit tests pass

Copilot AI linked an issue Apr 22, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix issue with adding new notification policy Fix Route: make fields optional and omit nulls in notification policy payload Apr 22, 2026
Copilot AI requested a review from ZPascal April 22, 2026 19:00
Copilot AI and others added 2 commits April 24, 2026 03:38
@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report
FileStmtsMissBranchBrPartCover
grafana_api
   \_\_init\_\_.py0000100%
   admin.py1600620100%
   alerting.py29901200100%
   alerting_notifications.py910360100%
   alerting_provisioning.py2280920100%
   annotations.py1180700100%
   api.py1220600100%
   authentication.py310100100%
   correlations.py620240100%
   dashboard.py24901160100%
   datasource.py29901280100%
   external_group.py340120100%
   folder.py1280580100%
   legacy_alerting.py630280100%
   legacy_playlist.py550220100%
   library.py840400100%
   licensing.py26060100%
   model.py373080100%
   organisation.py1510600100%
   other_http.py640180100%
   playlist.py800360100%
   preferences.py530240100%
   query_history.py700300100%
   rbac.py38801880100%
   reporting.py1740760100%
   search.py14040100%
   service_account.py1150460100%
   short_url.py16040100%
   snapshot.py540220100%
   sso_settings.py610220100%
   team.py1380620100%
   user.py1530620100%
tests/unittests
   test_admin.py346000100%
   test_alerting.py514000100%
   test_alerting_notifications.py175000100%
   test_alerting_provisioning.py374000100%
   test_annotations.py135000100%
   test_api.py176000100%
   test_authentication.py60000100%
   test_correlations.py124000100%
   test_dashboard.py498000100%
   test_datasource.py580000100%
   test_external_group.py65000100%
   test_folder.py248000100%
   test_legacy_alerting.py89000100%
   test_legacy_playlist.py109000100%
   test_library.py156000100%
   test_licensing.py52000100%
   test_model.py36000100%
   test_organisation.py228000100%
   test_other_http.py103000100%
   test_playlist.py167000100%
   test_preferences.py95000100%
   test_query_history.py129000100%
   test_rbac.py678000100%
   test_reporting.py315000100%
   test_search.py25000100%
   test_service_account.py173000100%
   test_short_url.py25000100%
   test_snapshot.py107000100%
   test_sso_settings.py103000100%
   test_team.py287000100%
   test_user.py336000100%
TOTAL10461015460100%
Tests Skipped Failures Errors Time
1007 0 💤 0 ❌ 0 🔥 5.634s ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New notification policy?

2 participants