Skip to content

feat: add slot advanced arguments#36

Merged
wizzomafizzo merged 1 commit into
mainfrom
feat/slot-advargs
Jun 11, 2026
Merged

feat: add slot advanced arguments#36
wizzomafizzo merged 1 commit into
mainfrom
feat/slot-advargs

Conversation

@wizzomafizzo

@wizzomafizzo wizzomafizzo commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

  • add a typed slot advanced argument key
  • expose slot on launch and playlist argument structs
  • cover slot advarg tags and key constant in tests

Validation

  • go test ./...
  • task lint

Summary by CodeRabbit

Release Notes

  • New Features
    • Added support for a slot argument in advanced arguments, enabling users to specify slot parameters when launching content and managing playlists.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: acd7cc4e-df89-4d6c-be32-671e5dbe9254

📥 Commits

Reviewing files that changed from the base of the PR and between a063fa4 and d1ab59f.

📒 Files selected for processing (3)
  • types.go
  • types_advargs_test.go
  • types_test.go

📝 Walkthrough

Walkthrough

This PR adds a new slot advanced argument to the ZapScript routing model. It introduces a KeySlot constant and extends six argument structs with a Slot field, then validates both the constant value and struct tag presence via two new tests.

Changes

Slot argument addition

Layer / File(s) Summary
Slot key constant and struct field definitions
types.go
Defines KeySlot constant as "slot" and adds Slot string fields tagged advarg:"slot" to LaunchArgs, LaunchRandomArgs, LaunchSearchArgs, LaunchTitleArgs, LaunchLastArgs, and PlaylistArgs.
Slot argument validation tests
types_test.go, types_advargs_test.go
Verifies KeySlot equals "slot" and confirms all routing argument structs include the advarg:"slot" struct tag.

Sequence Diagram

The changes are structural (data contract and validation) with no executable flow or interactions between components, so no sequence diagram is needed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • ZaparooProject/go-zapscript#28: Both PRs extend the same launch-related argument structs with new advanced-argument fields, adding slot vs. set_name/set_name_same_dir.
  • ZaparooProject/go-zapscript#29: Both PRs add new advarg-tagged fields to routing argument structs and update corresponding struct tag validation tests.

Poem

🐰 A slot emerges, defined with care,
Six structs now hold this routing pair,
With tests that verify it's right,
The arguments shine ever bright! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a new slot advanced argument feature across multiple structs with corresponding tests.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/slot-advargs

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wizzomafizzo wizzomafizzo merged commit 9722898 into main Jun 11, 2026
12 checks passed
@wizzomafizzo wizzomafizzo deleted the feat/slot-advargs branch June 11, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant