-
-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add device profiles #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -408,3 +408,35 @@ Sent when a new inbox message is added to the server. | |||||||||||||||
| } | ||||||||||||||||
| } | ||||||||||||||||
| ``` | ||||||||||||||||
|
|
||||||||||||||||
| ## Profiles | ||||||||||||||||
|
|
||||||||||||||||
| ### profiles.active | ||||||||||||||||
|
|
||||||||||||||||
| Sent when the device's active profile changes, including deactivation. | ||||||||||||||||
|
|
||||||||||||||||
| #### Parameters | ||||||||||||||||
|
|
||||||||||||||||
| | Key | Type | Required | Description | | ||||||||||||||||
| | :------ | :----- | :------- | :------------------------------------------------------------------ | | ||||||||||||||||
| | profile | object | Yes | The new active profile, or null when the device deactivated. | | ||||||||||||||||
|
|
||||||||||||||||
|
Comment on lines
+420
to
+423
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Document Line 420 currently lists Suggested diff-| profile | object | Yes | The new active profile, or null when the device deactivated. |
+| profile | object \| null | Yes | The new active profile, or null when the device deactivated. |📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
| The profile object contains `profileId`, `name`, `hasPin` and any playtime limit overrides (`limitsEnabled`, `dailyLimit`, `sessionLimit`). | ||||||||||||||||
|
|
||||||||||||||||
| #### Example | ||||||||||||||||
|
|
||||||||||||||||
| ```json | ||||||||||||||||
| { | ||||||||||||||||
| "jsonrpc": "2.0", | ||||||||||||||||
| "method": "profiles.active", | ||||||||||||||||
| "params": { | ||||||||||||||||
| "profile": { | ||||||||||||||||
| "profileId": "1ad28b9a-7aef-11ef-9817-020304050607", | ||||||||||||||||
| "name": "Kid A", | ||||||||||||||||
| "hasPin": true, | ||||||||||||||||
| "limitsEnabled": true, | ||||||||||||||||
| "dailyLimit": "2h" | ||||||||||||||||
| } | ||||||||||||||||
| } | ||||||||||||||||
| } | ||||||||||||||||
| ``` | ||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix heading level jump in the Profiles section.
Line 2458 jumps from
##to#####, which violates markdown heading increment rules and hurts generated outline/navigation.Suggested diff
📝 Committable suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 2458-2458: Heading levels should only increment by one level at a time
Expected: h3; Actual: h5
(MD001, heading-increment)
🤖 Prompt for AI Agents
Source: Linters/SAST tools