Tests: Use XCTFail where appropriate

Instead of XCTAssert(false) ...

Author: helje5

Tests/ZeeQLTests/AdaptorActiveRecordTestCase.swift

@@ -81,7 +81,7 @@ class AdapterActiveRecordTests: XCTestCase {
       try person.save()
     }
     catch {
-      XCTAssert(false, "save failed: \(error)")
+      XCTFail("save failed: \(error)")
     }
     if verbose { print("after save: \(person)") }
 
@@ -116,7 +116,7 @@ class AdapterActiveRecordTests: XCTestCase {
       try refetch?.delete()
     }
     catch {
-      XCTAssert(false, "delete failed: \(error)")
+      XCTFail("delete failed: \(error)")
     }
   }
 

Tests/ZeeQLTests/CodableModelTests.swift

@@ -919,19 +919,19 @@ class CodableModelTests: XCTestCase {
       }
     #else
       do {
-        try reflector.add(Person .self)
-        XCTAssert(false, "did not throw error")
+        try reflector.add(Person.self)
+        XCTFail("did not throw error")
       }
       catch let error as CodableModelDecoder.Error {
         if case .reflectionDepthExceeded = error {
           // good
         }
         else {
-          XCTAssert(false, "unexpected error: \(error)")
+          XCTFail("unexpected error: \(error)")
         }
       }
       catch {
-        XCTAssert(false, "unexpected error")
+        XCTFail("unexpected error")
       }
     #endif
 

Tests/ZeeQLTests/QualifierParserTests.swift

@@ -173,28 +173,28 @@ class QualifierParserTests: XCTestCase {
       XCTAssertEqual(v, "lastname = ", "1st raw value doesn't match")
     }
     else {
-      XCTAssertTrue(false, "first part is not a SQL value: \(parts[0])")
+      XCTFail("first part is not a SQL value: \(parts[0])")
     }
 
     if case .QualifierVariable(let id) = parts[1] {
       XCTAssertEqual(id, "lastname", "2nd part qvar doesn't match")
     }
     else {
-      XCTAssertTrue(false, "2nd part is not a QualifierVariable: \(parts[1])")
+      XCTFail("2nd part is not a QualifierVariable: \(parts[1])")
     }
 
     if case .RawSQLValue(let v) = parts[2] {
       XCTAssertEqual(v, " AND balance = ", "3rd raw value doesn't match")
     }
     else {
-      XCTAssertTrue(false, "3rd part is not a SQL value: \(parts[2])")
+      XCTFail("3rd part is not a SQL value: \(parts[2])")
     }
 
     if case .QualifierVariable(let id) = parts[3] {
       XCTAssertEqual(id, "balance", "4th part qvar doesn't match")
     }
     else {
-      XCTAssertTrue(false, "4th part is not a QualifierVariable: \(parts[3])")
+      XCTFail("4th part is not a QualifierVariable: \(parts[3])")
     }
   }