style: update lints and code

Author: Zekfad

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.3.1
+
+- Fix lint errors.
+- Use `package:zekfad_lints/lib.yaml` which aligns with core lints.
+
 ## 2.3.0
 
 > Requires Dart 3.6

README.md

@@ -22,8 +22,8 @@ This package provides WASM-ready Dart bindings to JavaScript
 ## Some notes about `fetch` and `Request`
 
 `fetch` and `Request` have same options but different semantics, e.g. `fetch`'s
-default mode is `no-cors` while `Request`'s `cors`. Therefore options objects
-for `fetch` function and `Request` constructor made as different extension
+default mode is `no-cors` while `Request`'s `cors`. Therefore, options objects
+of `fetch` function and `Request` constructor made as different extension
 types, although they are interchangeable and both inherited from `RequestInit`.
 
-For more info about that read [MDN docs](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API).
+For more info about that, read [MDN docs](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API).

analysis_options.yaml

@@ -1,5 +1 @@
-include: package:zekfad_lints/recommended.yaml
-
-linter:
-  rules:
-    public_member_api_docs: true
+include: package:zekfad_lints/lib.yaml

lib/src/iterator/extensions.dart

@@ -20,8 +20,9 @@ extension CoreIteratorToJSIterator<T extends JSAny> on core.Iterator<T> {
   js.Iterator get toJS =>
     js.Iterator<T>(
       next: ([value]) {
-        if (!moveNext())
+        if (!moveNext()) {
           return js.IteratorResult(done: true);
+        }
         return js.IteratorResult(value: current);
       },
     );

lib/src/iterator/iterator.dart

@@ -20,10 +20,12 @@ extension type Iterator<T extends JSAny>._(JSObject _) implements JSObject {
     IteratorResult<T> Function([JSAny? error])? throwValue,
   }) {
     final object = Iterator._new$1(next: IteratorMethod(next));
-    if (returnValue != null)
+    if (returnValue != null) {
       object._return = IteratorMethod(returnValue);
-    if (throwValue != null)
+    }
+    if (throwValue != null) {
       object._throw = IteratorMethod(throwValue);
+    }
     object._.setProperty(
       _symbolIterator,
       IteratorSymbolMethod(() => object),
@@ -61,10 +63,11 @@ extension type Iterator<T extends JSAny>._(JSObject _) implements JSObject {
   /// and can perform any cleanup actions.
   IteratorResult<T> Function([T? value])? get returnValue => _return?.bind(_).call;
   set returnValue(IteratorResult<T> Function([T? value])? fn) {
-    if (fn == null)
+    if (fn == null) {
       _.delete('return'.toJS);
-    else
+    } else {
       _return = IteratorMethod<T, T>(fn);
+    }
   }
 
   /// A function that accepts zero or one argument and returns an object
@@ -74,10 +77,11 @@ extension type Iterator<T extends JSAny>._(JSObject _) implements JSObject {
   /// condition, and exception is typically an `Error` instance.
   IteratorResult<T> Function([JSAny? value])? get throwValue => _throw?.bind(_).call;
   set throwValue(IteratorResult<T> Function([JSAny? value])? fn) {
-    if (fn == null)
+    if (fn == null) {
       _.delete('throw'.toJS);
-    else
+    } else {
       _throw = IteratorMethod<T, JSAny>(fn);
+    }
   }
 
   @JS('next')

lib/src/js_define_property/js_accessor_descriptor.dart

@@ -19,10 +19,12 @@ extension type JSAccessorDescriptor<T extends JSObject, R extends JSAny?>._(JSPr
       configurable: configurable,
       enumerable: enumerable,
     );
-    if (get != null)
+    if (get != null) {
       descriptor.get = JSAccessorDescriptorGetterMethod<T, R>(get);
-    if (set != null)
+    }
+    if (set != null) {
       descriptor.set = JSAccessorDescriptorSetterMethod<T>(set);
+    }
     return descriptor;
   }
 

lib/src/readable_stream/readable_stream.dart

@@ -17,12 +17,14 @@ extension type ReadableStream<T extends JSAny, AbortType extends JSAny>._(JSObje
     JSObject? queuingStrategy,
   ]) {
     if (underlyingSource != null) {
-      if (queuingStrategy != null)
+      if (queuingStrategy != null) {
         return ReadableStream._new$2(underlyingSource, queuingStrategy);
-      else
+      } else {
         return ReadableStream._new$1(underlyingSource);
-    } else
+      }
+    } else {
       return ReadableStream._new$0();
+    }
   }
 
   /// Creates and returns a readable stream object.

lib/src/readable_stream/readable_stream_default_reader.dart

@@ -58,8 +58,9 @@ extension type ReadableStreamDefaultReader<T extends JSAny, AbortType extends JS
       ReadableStreamDefaultReaderChunk<T> chunk;
       do {
         chunk = await read();
-        if (chunk.value case final value?)
+        if (chunk.value case final value?) {
           yield value;
+        }
       } while (!chunk.done);
       return;
     } catch(_) {
@@ -69,8 +70,9 @@ extension type ReadableStreamDefaultReader<T extends JSAny, AbortType extends JS
       // Cancel stream after full read or early break.
       // If used with fetch response, this will cancel further response body
       // download on subscription cancellation and save bandwidth.
-      if (!error)
+      if (!error) {
         await cancel();
+      }
     }
   }
 }

lib/src/readable_stream/readable_stream_source.dart

@@ -24,16 +24,21 @@ extension type ReadableStreamSource<T extends JSAny, AbortType extends JSAny>._(
     int? autoAllocateChunkSize,
   }) {
     final object = JSObject() as ReadableStreamSource<T, AbortType>;
-    if (start != null)
+    if (start != null) {
       object.start = ReadableStreamSourceControllerMethod(start);
-    if (pull != null)
+    }
+    if (pull != null) {
       object.pull = ReadableStreamSourceControllerMethod(pull);
-    if (cancel != null)
+    }
+    if (cancel != null) {
       object.cancel = ReadableStreamSourceCancelMethod<T, JSAny?, AbortType>(cancel);
-    if (type != null)
+    }
+    if (type != null) {
       object.type = type;
-    if (autoAllocateChunkSize != null)
+    }
+    if (autoAllocateChunkSize != null) {
       object.autoAllocateChunkSize = autoAllocateChunkSize;
+    }
     return object;
   }
 
@@ -48,8 +53,9 @@ extension type ReadableStreamSource<T extends JSAny, AbortType extends JSAny>._(
         subscription = stream.listen(
           (event) {
             controller.enqueue(event);
-            if (controller.desiredSize <= 0)
+            if (controller.desiredSize <= 0) {
               subscription.pause();
+            }
           },
           onError: (Object error) {
             final object = switch (error) {
@@ -66,12 +72,15 @@ extension type ReadableStreamSource<T extends JSAny, AbortType extends JSAny>._(
           },
           cancelOnError: true,
         );
+        return;
       },
       pull: (controller) {
         subscription.resume();
+        return;
       },
       cancel: (reason, controller) async {
         await subscription.cancel();
+        return;
       },
     );
   }

lib/src/request/request_body.dart

@@ -39,17 +39,17 @@ extension type const RequestBody._(JSAny _) implements JSAny {
   const factory RequestBody.fromReadableStream(ReadableStream<JSUint8Array, JSAny> body) = _RequestBodyReadableStream;
 
   /// Try to create [RequestBody] from JS value.
-  factory RequestBody.fromJSAny(JSAny _body) => switch(_body) {
-    final JSString body when _body.isA<JSString>() => RequestBody.fromJSString(body),
-    final JSArrayBuffer body when _body.isA<JSArrayBuffer>() => RequestBody.fromJSArrayBuffer(body),
-    final Blob body when _body.isA<Blob>() => RequestBody.fromBlob(body),
-    final JSDataView body when _body.isA<JSDataView>() => RequestBody.fromJSDataView(body),
-    final File body when _body.isA<File>() => RequestBody.fromFile(body),
-    final FormData body when _body.isA<FormData>() => RequestBody.fromFormData(body),
-    final JSTypedArray body when _body.isA<JSTypedArray>() => RequestBody.fromJSTypedArray(body),
-    final URLSearchParams body when _body.isA<URLSearchParams>() => RequestBody.fromURLSearchParams(body),
-    final ReadableStream<JSUint8Array, JSAny> body when _body.isA<ReadableStream<JSUint8Array, JSAny>>()  => RequestBody.fromReadableStream(body),
-    _ => throw JSTypeError('${_body.runtimeType} is not a valid RequestBody'),
+  factory RequestBody.fromJSAny(JSAny body) => switch(body) {
+    final JSString body when body.isA<JSString>() => RequestBody.fromJSString(body),
+    final JSArrayBuffer body when body.isA<JSArrayBuffer>() => RequestBody.fromJSArrayBuffer(body),
+    final Blob body when body.isA<Blob>() => RequestBody.fromBlob(body),
+    final JSDataView body when body.isA<JSDataView>() => RequestBody.fromJSDataView(body),
+    final File body when body.isA<File>() => RequestBody.fromFile(body),
+    final FormData body when body.isA<FormData>() => RequestBody.fromFormData(body),
+    final JSTypedArray body when body.isA<JSTypedArray>() => RequestBody.fromJSTypedArray(body),
+    final URLSearchParams body when body.isA<URLSearchParams>() => RequestBody.fromURLSearchParams(body),
+    final ReadableStream<JSUint8Array, JSAny> body when body.isA<ReadableStream<JSUint8Array, JSAny>>()  => RequestBody.fromReadableStream(body),
+    _ => throw JSTypeError('${body.runtimeType} is not a valid RequestBody'),
   };
 
   /// Convert to target JS value.