Skip to content

ci(pr): add a finalizer to monitor for success#5

Merged
JonZeolla merged 6 commits into
mainfrom
ci/add-finalizer
Jul 2, 2025
Merged

ci(pr): add a finalizer to monitor for success#5
JonZeolla merged 6 commits into
mainfrom
ci/add-finalizer

Conversation

@JonZeolla

Copy link
Copy Markdown
Member

Contributor Comments

This adds a "finalizer" to simplify the configuration of policy requirements. For example, after this merges the following can be replaced with just a check on the finalizer after this merges. It seems trivial, but if you follow this and this link you can see how it is very powerful.

Screenshot 2025-07-02 at 4 37 42 PM

Pull Request Checklist

Thank you for submitting a contribution!

Please address the following items:

  • If you are adding a dependency, please explain how it was chosen.
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
  • Validate that documentation is accurate and aligned to any project updates or additions.

@JonZeolla JonZeolla enabled auto-merge (squash) July 2, 2025 20:40

@ai-coding-guardrails ai-coding-guardrails Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got 1 comment for you to consider

Reviewed with 🤟 by Zenable

Comment thread .github/workflows/ci.yml Fixed
JonZeolla and others added 3 commits July 2, 2025 16:44
…ws/ci.yml

Co-authored-by: ai-coding-guardrails[bot] <206064491+ai-coding-guardrails[bot]@users.noreply.github.com>
@JonZeolla

Copy link
Copy Markdown
Member Author

I tested generating a project and opening a PR and it worked:
Screenshot 2025-07-02 at 5 15 29 PM

Same thing here:
Screenshot 2025-07-02 at 5 15 53 PM

@JonZeolla JonZeolla disabled auto-merge July 2, 2025 21:18
@JonZeolla JonZeolla enabled auto-merge (squash) July 2, 2025 21:18
@JonZeolla JonZeolla merged commit e2e83ca into main Jul 2, 2025
8 checks passed
@JonZeolla JonZeolla deleted the ci/add-finalizer branch July 4, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants