Upload file

Author: Zenlua

common/src/main/java/com/omarea/common/ui/DialogAppChooser.kt

@@ -47,19 +47,21 @@ class DialogAppChooser(
                 val adapter = absListView.adapter as? AdapterAppChooser
                 selectAll.visibility = View.VISIBLE
                 selectAll.isChecked =
-                    packages.isNotEmpty() &&
-                    packages.size > 1 &&
-                    packages.count { it.selected } == packages.size
+                    adapter != null &&
+                    adapter.count > 0 &&
+                    adapter.getSelectedItems().size == adapter.count
 
                 selectAll.setOnClickListener {
                     adapter?.setSelectAllState((it as CompoundButton).isChecked)
                 }
 
-                adapter?.setSelectStateListener(object : AdapterAppChooser.SelectStateListener {
-                    override fun onSelectChange(selected: List<AdapterAppChooser.AppInfo>) {
-                        selectAll.isChecked = selected.size == packages.size
-                    }
-                })
+                adapter?.let { ad ->
+                    ad.setSelectStateListener(object : AdapterAppChooser.SelectStateListener {
+                        override fun onSelectChange(selected: List<AdapterAppChooser.AppInfo>) {
+                            selectAll.isChecked = selected.size == ad.count
+                        }
+                    })
+                }
 
                 if (!allowAllSelect) {
                     selectAll.visibility = View.GONE
@@ -162,5 +164,8 @@ class DialogAppChooser(
 
     override fun onDismiss(dialog: DialogInterface) {
         super.onDismiss(dialog)
+        if (::adapter.isInitialized) {
+            adapter.release()
+        }
     }
 }

krscript/src/main/java/com/omarea/krscript/ui/ParamsAppChooserRender.kt

@@ -61,11 +61,6 @@ class ParamsAppChooserRender(
     private fun openAppChooser() {
         // 🔥 preload app đã chọn → có appName
         packages = preloadSelectedApps()
-
-if (packages.isEmpty()) {
-    // đảm bảo dialog không hiểu nhầm có selection
-    packages.clear()
-}
 
         val dialog = DialogAppChooser(
             darkMode,
@@ -234,74 +229,74 @@ if (packages.isEmpty()) {
         }
     }
 
-private fun resolveCurrentAppName() {
-    val pm = context.packageManager
-
-    if (actionParamInfo.multiple) {
-        val pkgs = valueView.text.toString()
-            .split(actionParamInfo.separator)
-            .filter { it.isNotEmpty() }
-
-        val names = ArrayList<String>(pkgs.size)
-        for (pkg in pkgs) {
-            try {
-                val app = pm.getApplicationInfo(pkg, 0)
-                names.add(app.loadLabel(pm)?.toString() ?: pkg)
-            } catch (_: Exception) {
-                names.add(pkg)
+    private fun resolveCurrentAppName() {
+        val pm = context.packageManager
+    
+        if (actionParamInfo.multiple) {
+            val pkgs = valueView.text.toString()
+                .split(actionParamInfo.separator)
+                .filter { it.isNotEmpty() }
+    
+            val names = ArrayList<String>(pkgs.size)
+            for (pkg in pkgs) {
+                try {
+                    val app = pm.getApplicationInfo(pkg, 0)
+                    names.add(app.loadLabel(pm)?.toString() ?: pkg)
+                } catch (_: Exception) {
+                    names.add(pkg)
+                }
+            }
+            nameView.text = names.joinToString("，")
+        } else {
+            val pkg = valueView.text.toString()
+            if (pkg.isNotEmpty()) {
+                try {
+                    val app = pm.getApplicationInfo(pkg, 0)
+                    nameView.text = app.loadLabel(pm)?.toString() ?: pkg
+                } catch (_: Exception) {
+                    nameView.text = pkg
+                }
             }
         }
-        nameView.text = names.joinToString("，")
-    } else {
-        val pkg = valueView.text.toString()
-        if (pkg.isNotEmpty()) {
+    }
+
+    private fun preloadSelectedApps(): ArrayList<AdapterAppChooser.AppInfo> {
+        val pm = context.packageManager
+        val result = ArrayList<AdapterAppChooser.AppInfo>()
+    
+        val values = if (actionParamInfo.multiple) {
+            valueView.text.toString()
+                .split(actionParamInfo.separator)
+                .filter { it.isNotEmpty() }
+        } else {
+            listOf(valueView.text.toString()).filter { it.isNotEmpty() }
+        }
+    
+        // ✅ nếu chưa chọn gì → trả list rỗng
+        if (values.isEmpty()) return result
+    
+        for (pkg in values) {
             try {
                 val app = pm.getApplicationInfo(pkg, 0)
-                nameView.text = app.loadLabel(pm)?.toString() ?: pkg
+                result.add(
+                    AdapterAppChooser.AppInfo().apply {
+                        packageName = pkg
+                        appName = app.loadLabel(pm)?.toString() ?: pkg
+                        selected = true
+                    }
+                )
             } catch (_: Exception) {
-                nameView.text = pkg
+                result.add(
+                    AdapterAppChooser.AppInfo().apply {
+                        packageName = pkg
+                        appName = pkg
+                        selected = true
+                    }
+                )
             }
         }
+        return result
     }
-}
-
-private fun preloadSelectedApps(): ArrayList<AdapterAppChooser.AppInfo> {
-    val pm = context.packageManager
-    val result = ArrayList<AdapterAppChooser.AppInfo>()
-
-    val values = if (actionParamInfo.multiple) {
-        valueView.text.toString()
-            .split(actionParamInfo.separator)
-            .filter { it.isNotEmpty() }
-    } else {
-        listOf(valueView.text.toString()).filter { it.isNotEmpty() }
-    }
-
-    // ✅ nếu chưa chọn gì → trả list rỗng
-    if (values.isEmpty()) return result
-
-    for (pkg in values) {
-        try {
-            val app = pm.getApplicationInfo(pkg, 0)
-            result.add(
-                AdapterAppChooser.AppInfo().apply {
-                    packageName = pkg
-                    appName = app.loadLabel(pm)?.toString() ?: pkg
-                    selected = true
-                }
-            )
-        } catch (_: Exception) {
-            result.add(
-                AdapterAppChooser.AppInfo().apply {
-                    packageName = pkg
-                    appName = pkg
-                    selected = true
-                }
-            )
-        }
-    }
-    return result
-}
     // =======================
     // CALLBACK
     // =======================