fix: credential.id is already base64url from verifyRegistrationResponse, don't double-encode

ddrayko · ddrayko · commit 6e16d7510081 · 2026-07-03T17:48:19.000+02:00
diff --git a/routes/passkeys.js b/routes/passkeys.js
@@ -120,7 +120,7 @@ router.post('/passkeys/register/complete', authenticateToken, async (req, res) =
       'INSERT INTO passkeys (user_id, credential_id, public_key, counter, transports, name) VALUES (?, ?, ?, ?, ?, ?)',
       [
         userId,
-        isoBase64URL.fromBuffer(credential.id),
+        credential.id,
         isoBase64URL.fromBuffer(credential.publicKey),
         credential.counter,
         (credential.transports || []).join(','),

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ router.post('/passkeys/register/complete', authenticateToken, async (req, res) =`
`120`	`120`	`'INSERT INTO passkeys (user_id, credential_id, public_key, counter, transports, name) VALUES (?, ?, ?, ?, ?, ?)',`
`121`	`121`	`[`
`122`	`122`	`userId,`
`123`		`- isoBase64URL.fromBuffer(credential.id),`
	`123`	`+ credential.id,`
`124`	`124`	`isoBase64URL.fromBuffer(credential.publicKey),`
`125`	`125`	`credential.counter,`
`126`	`126`	`(credential.transports \|\| []).join(','),`