Fix memory leak.

Author: ZeroIntensity

Lib/test/test_interpreters/test_api.py

@@ -2371,7 +2371,7 @@ def __init__(self):
 
             def __del__(self):
                 self._dummy.close()
-                if self.file:
+                if self.file is not None:
                     self.file.write("done")
 
             def foo(self):
@@ -2385,6 +2385,15 @@ def interp(self):
         self.assertFalse(is_pickleable(obj))
         return obj
 
+    @contextlib.contextmanager
+    def share(self, obj, *, expect_proxy=True):
+        with interpreters.share(obj) as proxy:
+            self.assertTrue(_interpreters.is_shareable(proxy))
+            if expect_proxy:
+                self.assertTrue(sys._is_immortal(proxy))
+                self.assertFalse(is_pickleable(proxy))
+            yield proxy
+
     def test_simple_proxy(self):
         interp = interpreters.create()
         try:
@@ -2395,10 +2404,7 @@ def get_unshareable(obj):
             def get_interp(obj):
                 return obj.interp().id
 
-            with interpreters.share(self.unshareable()) as proxy:
-                self.assertTrue(_interpreters.is_shareable(proxy))
-                self.assertTrue(sys._is_immortal(proxy))
-                self.assertFalse(is_pickleable(proxy))
+            with self.share(self.unshareable()) as proxy:
                 self.assertEqual(interp.call(get_unshareable, proxy), 24)
                 self.assertEqual(interp.call(get_interp, proxy), interpreters.get_current().id)
         finally:
@@ -2413,9 +2419,9 @@ def test_object_collected_after_proxy_closes(self):
             def write_to_proxy(obj):
                 obj.file.write("hello")
 
-            with interpreters.share(self.unshareable(buffer)) as proxy:
-                self.assertFalse(is_pickleable(proxy))
+            with self.share(self.unshareable(buffer)) as proxy:
                 self.assertIsNone(interp.call(write_to_proxy, proxy))
+                self.assertEqual(str(proxy.file), buffer)
 
             self.assertEqual(buffer.getvalue(), "hellodone")
         finally:

Modules/_interpretersmodule.c

@@ -836,7 +836,7 @@ _sharedobjectproxy_wrap_result(SharedObjectProxy *self, PyObject *result,
     }
 
     PyObject *ret = _sharedobjectproxy_as_shared(&shared_result);
-    //_sharedobjectproxy_finish_share(&shared_result);
+    _sharedobjectproxy_finish_share(&shared_result);
     return ret;
 }