Skip to content

Commit a174013

Browse files
committed
VERSION{v1.14.4.0}
Reset PW notification to default off for everyone. Fix activity prompt with zero charges. Text tweak.
1 parent 76d7eb4 commit a174013

4 files changed

Lines changed: 11 additions & 7 deletions

File tree

LuaMenu/widgets/chobby/components/configuration.lua

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ function Configuration:init()
210210
self.lastLoginChatLength = 25
211211
self.notifyForAllChat = true
212212
self.autosaveOnMatchmaker = true
213-
self.planetwarsNotifications = false -- Possibly too intrusive? See how it goes.
213+
self.planetwarsNotifications2 = false -- Possibly too intrusive? See how it goes.
214214
self.ingameNotifcations = true -- Party, chat
215215
self.nonFriendNotifications = true -- Party, chat
216216
self.friendNotifyIngame = true
@@ -583,7 +583,7 @@ function Configuration:GetConfigData()
583583
animate_lobby = self.animate_lobby,
584584
game_settings = self.game_settings,
585585
notifyForAllChat = self.notifyForAllChat,
586-
planetwarsNotifications = self.planetwarsNotifications,
586+
planetwarsNotifications2 = self.planetwarsNotifications2,
587587
ingameNotifcations = self.ingameNotifcations,
588588
nonFriendNotifications = self.nonFriendNotifications,
589589
friendNotifyIngame = self.friendNotifyIngame,

LuaMenu/widgets/gui_planetwars_list_window.lua

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,10 @@ local function GetActivityToPrompt(lobby, attackerFactions, defenderFactions, cu
169169
return myPlanet, attackPhase, true, not attackPhase
170170
end
171171
end
172+
173+
if attackPhase and lobby.planetwarsData.charges == 0 then
174+
return false -- Cannot attack with no charges
175+
end
172176

173177
if IsPhaseUrgent() then
174178
local targetPlanet, minMissing
@@ -469,7 +473,7 @@ local function InitializeActivityPromptHandler()
469473
end
470474
newNotification = false
471475
oldIsAttacker = isAttacker
472-
if not Configuration.planetwarsNotifications then
476+
if not Configuration.planetwarsNotifications2 then
473477
return
474478
end
475479
if WG.WrapperLoopback then
@@ -492,7 +496,6 @@ local function InitializeActivityPromptHandler()
492496
Spring.SetConfigString("snd_volui", snd_volui)
493497
Spring.SetConfigString("snd_volmaster", snd_volmaster)
494498
end, 10)
495-
496499
end
497500

498501
holder.OnResize = {Resize}
@@ -1388,9 +1391,9 @@ local function InitializeControls(window)
13881391

13891392
if attackPhase then
13901393
if charges == 0 then
1391-
statusText:SetText("You are out of attack charges. Regain charges by defending or waiting for the recharge timer.")
1394+
statusText:SetText("You are out of attack charges. Gain charges by defending or over time.")
13921395
else
1393-
statusText:SetText("Select a planet to attack and wait for allies to join you. Attacks lock at the end of the phase and request defenders.")
1396+
statusText:SetText("Select a planet to attack. Invasions with enough players are locked at the end of the phase and sent to the defenders.")
13941397
end
13951398
if planets then
13961399
UpdatePlanetStatusData(attackPhase, planets)

LuaMenu/widgets/gui_settings_window.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -980,7 +980,7 @@ local function GetLobbyTabControls()
980980
end
981981
children[#children + 1], offset = AddCheckboxSetting(offset, "Multiplayer in new window", "multiplayerLaunchNewSpring", true)
982982
if not Configuration.gameConfig.disablePlanetwars then
983-
children[#children + 1], offset = AddCheckboxSetting(offset, i18n("planetwars_notifications"), "planetwarsNotifications", false)
983+
children[#children + 1], offset = AddCheckboxSetting(offset, i18n("planetwars_notifications"), "planetwarsNotifications2", false)
984984
end
985985

986986
children[#children + 1], offset = AddCheckboxSetting(offset, "Autosave SP on matchmaker", "autosaveOnMatchmaker", true)

modinfo.lua

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,4 @@ local modinfo = {
1919
}
2020

2121
return modinfo
22+

0 commit comments

Comments
 (0)