Use Spring.SetUnitAlwaysUpdateMatrix to draw cloak fading units (thanks ivand).

Tweak visuals a little.

Author: GoogleFrog

LuaRules/Gadgets/cus_gl4.lua

@@ -347,7 +347,7 @@ local initiated = false
 local featuresDefsWithAlpha = {} -- featureDefIDs (ie trees) that should be drawn with alpha.
 local unitDefsUseSkinning = {} -- unitDefIDs that use the bones and stretchy skin system
 
-local ENEMY_CLOAK_FRAMES = false -- 4 -- How many extra frames to show enemy units for.
+local ENEMY_CLOAK_FRAMES = 10 -- How many extra frames to show enemy units for.
 local cloakDeferFrame = {}
 local keepDrawFlagChecking = false -- a list of units that need draw flag checking
 
@@ -1425,24 +1425,27 @@ local function RemoveObject(objectID, reason) -- we get pos/neg objectID here
 	end
 end
 
-local function ProcessCusUnit(unitID, drawFlag,  gameFrame, reason)
+local function ProcessCusUnit(unitID, drawFlag, gameFrame, reason)
 	if debugmode then Spring.Echo("ProcessUnits", unitID, drawFlag, reason) end
 
 	if cloakDeferFrame[unitID] and ((not drawFlag) or drawFlag == 0) then
 		if cloakDeferFrame[unitID] < gameFrame then
 			cloakDeferFrame[unitID] = nil
 		end
 		if not Spring.ValidUnitID(unitID) then
+			cloakDeferFrame[unitID] = nil
 			return
 		end
 		if cloakDeferFrame[unitID] then
 			drawFlag = 1
 			keepDrawFlagChecking = keepDrawFlagChecking or {}
 			keepDrawFlagChecking[#keepDrawFlagChecking + 1] = unitID
+		else
+			Spring.SetUnitAlwaysUpdateMatrix(unitID, false)
 		end
 	end
 	if not drawFlag then
-		drawFlag = Spring.GetUnitDrawFlag(unitID)
+		drawFlag = Spring.GetUnitDrawFlag(unitID) or 0
 	end
 
 	if math_bit_and(drawFlag, 34) > 0 then -- has alpha (2) or alphashadow(32) flag
@@ -2071,6 +2074,7 @@ function gadget:UnitCloaked(unitID)
 		gl.SetUnitBufferUniforms(unitID, uniformCache, 12)
 		wantTranparent[unitID] = true
 		if not allyUnit then
+			Spring.SetUnitAlwaysUpdateMatrix(unitID, true)
 			keepDrawFlagChecking = keepDrawFlagChecking or {}
 			keepDrawFlagChecking[#keepDrawFlagChecking + 1] = unitID
 			cloakDeferFrame[unitID] = frame + ENEMY_CLOAK_FRAMES

LuaRules/Gadgets/lups_cloak_fx.lua

@@ -82,7 +82,7 @@ local CloakEffect      = {
   { class='Sound',options={ file="sounds/cloak.wav",volume=0.9 } },
 }
 local EnemyCloakEffect      = {
-  { class='UnitCloaker',options={ life=30} },
+  --{ class='UnitCloaker',options={ life=30} },
   { class='Sound',options={ file="sounds/cloak.wav",volume=0.9 } },
 }
 

ModelMaterials_GL4/templates/cus_gl4.frag.glsl

@@ -1302,16 +1302,16 @@ void main(void){
 			if (cloakTime > 0){
 				if (isEnemy) {
 					cloakTime = cloakTime - 1000000.0;
-					cloakedness = (timeInfo.x - cloakTime) / 4.0;
-					if (cloakedness > 2.0) {
+					cloakedness = (timeInfo.x - cloakTime) / 9.0;
+					if (cloakedness > 1.5) {
 						// Enough time has passed to fully hide the unit, must be a spectator with a bad state
 						isEnemy = false;
 					} else {
 						outlineValue = 0.0;
 					}
 					cloakedness = clamp(cloakedness, 0.0, 1.0);
 				} else {
-					cloakedness = clamp((timeInfo.x - cloakTime) / 8.0, 0.0, 1.0);
+					cloakedness = clamp((timeInfo.x - cloakTime) / 9.0, 0.0, 1.0);
 				}
 				//outColor.g = 1.0;
 			}
@@ -1329,11 +1329,11 @@ void main(void){
 			float perlinline2 = clamp(1.0 - 20* abs(myPerlin.g - fract(simFrame * 0.005 + 0.5)), 0.0, 1.0);
 			float cloaknoise = cloakedness*perlinline1 + cloakedness*perlinline2;
 			if (isEnemy) {
-				texColor2.a = 1.0 - clamp(cloakedness * (1.0 + cloaknoise * 5.0), 0.0, 1.0);
+				texColor2.a = 1.0 - clamp(cloakedness * (1.0 + cloaknoise * 2.0), 0.0, 1.0);
 			} else {
-				outColor.rgb = mix(outColor.rgb, teamCol.rgb, cloakedness*0.5);
+				outColor.rgb = mix(outColor.rgb, teamCol.rgb, cloakedness*(0.2 + (perlinline2 + perlinline2) * 1.5));
 			}
-			outColor.rgb += cloaknoise * 0.85;
+			outColor.rgb += cloaknoise * 0.8;
 
 			#if 1
 			float dotcamera = dot(worldNormal, V);